MCO-1675: Update API for Status Reporting needs (REBASED) #2442
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@isabella-janssen: This pull request references MCO-1675 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Hello @isabella-janssen! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/XXL
|
/retitle MCO-1675: Update API for Status Reporting needs (REBASED) |
openshift-ci
bot
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@isabella-janssen: This pull request references MCO-1675 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/override ci/prow/verify-crd-schema False positives, new required field has a new optional parent /test e2e-aws-serial-techpreview-2of2 |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
|
/test e2e-aws-serial-techpreview-2of2 |
|
Overriding the /override ci/prow/verify-crd-schema |
|
@everettraven: Overrode contexts on behalf of everettraven: ci/prow/verify-crd-schema In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/verify-crd-schema |
|
@everettraven: Overrode contexts on behalf of everettraven: ci/prow/verify-crd-schema In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold Revision daaca27 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
1 similar comment
|
/retest-required |
|
@isabella-janssen Who is the QE assigned to this feature? We need to assign someone to either pre-merge verify the changes here if possible, or, assign to verify later |
|
@JoelSpeed QE for this feature is @ptalgulk01. We will probably want to do post-merge verification, but I will reach out to her to see what the testing plan will be for this feature. Thanks for the heads up! |
|
If you agree on post merge, you'll need to comment here with |
|
/verified by testing against existing MCN e2e cases |
openshift-ci-robot
added
the
verified
|
@ptalgulk01: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-ovn-techpreview |
|
@isabella-janssen: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@JoelSpeed It looks like the |
This recreates #2383 with an added commit to resolve the PR's merge conflicts.
Work included
omitemptytag tospec.configImage.desiredImageto meet new validation standard introduced with Update KAL to support new guidance on required and optional fields #2440.