Skip to content

Monitoring API: Add KubeStateMetrics api #2461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Monitoring API: Add KubeStateMetrics api #2461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
557334f
Add metric server API
marioferh Aug 29, 2025
1b8a123
KubeStateMetrics api
marioferh Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 143 additions & 0 deletions config/v1alpha1/tests/clustermonitoring.config.openshift.io/ClusterMonitoringConfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,3 +208,146 @@ tests:
request: "500m"
limit: "200m"
expectedError: 'spec.alertmanagerConfig.customConfig.resources[0]: Invalid value: "object": limit must be greater than or equal to request'
- name: Should be able to create a minimal MetricsServerConfig
initial: |
apiVersion: config.openshift.io/v1alpha1
kind: ClusterMonitoring
spec:
metricsServerConfig:
verbosity: Info
expected: |
apiVersion: config.openshift.io/v1alpha1
kind: ClusterMonitoring
spec:
metricsServerConfig:
verbosity: Info
- name: Should accept MetricsServerConfig with comprehensive ContainerResource array
initial: |
apiVersion: config.openshift.io/v1alpha1
kind: ClusterMonitoring
spec:
userDefined:
mode: "Disabled"
metricsServerConfig:
resources:
- name: "cpu"
request: "100m"
limit: "500m"
- name: "memory"
request: "128Mi"
limit: "512Mi"
- name: "ephemeral-storage"
request: "1Gi"
limit: "2Gi"
expected: |
apiVersion: config.openshift.io/v1alpha1
kind: ClusterMonitoring
spec:
userDefined:
mode: "Disabled"
metricsServerConfig:
resources:
- name: "cpu"
request: "100m"
limit: "500m"
- name: "memory"
request: "128Mi"
limit: "512Mi"
- name: "ephemeral-storage"
request: "1Gi"
limit: "2Gi"
- name: Should accept MetricsServerConfig with only requests
initial: |
apiVersion: config.openshift.io/v1alpha1
kind: ClusterMonitoring
spec:
userDefined:
mode: "Disabled"
metricsServerConfig:
resources:
- name: "cpu"
request: "200m"
- name: "memory"
request: "256Mi"
expected: |
apiVersion: config.openshift.io/v1alpha1
kind: ClusterMonitoring
spec:
userDefined:
mode: "Disabled"
metricsServerConfig:
resources:
- name: "cpu"
request: "200m"
- name: "memory"
request: "256Mi"
- name: Should accept MetricsServerConfig with only limits
initial: |
apiVersion: config.openshift.io/v1alpha1
kind: ClusterMonitoring
spec:
userDefined:
mode: "Disabled"
metricsServerConfig:
resources:
- name: "cpu"
limit: "1"
- name: "memory"
limit: "1Gi"
expected: |
apiVersion: config.openshift.io/v1alpha1
kind: ClusterMonitoring
spec:
userDefined:
mode: "Disabled"
metricsServerConfig:
resources:
- name: "cpu"
limit: "1"
- name: "memory"
limit: "1Gi"
- name: Should reject MetricsServerConfig with limit less than request
initial: |
apiVersion: config.openshift.io/v1alpha1
kind: ClusterMonitoring
spec:
userDefined:
mode: "Disabled"
metricsServerConfig:
resources:
- name: "cpu"
request: "500m"
limit: "200m"
expectedError: 'spec.metricsServerConfig.resources[0]: Invalid value: "object": limit must be greater than or equal to request'
- name: Should reject MetricsServerConfig with more than 10 resource items
initial: |
apiVersion: config.openshift.io/v1alpha1
kind: ClusterMonitoring
spec:
userDefined:
mode: "Disabled"
metricsServerConfig:
resources:
- name: "cpu"
request: "100m"
- name: "memory"
request: "64Mi"
- name: "hugepages-2Mi"
request: "32Mi"
- name: "hugepages-1Gi"
request: "1Gi"
- name: "ephemeral-storage"
request: "1Gi"
- name: "nvidia.com/gpu"
request: "1"
- name: "example.com/foo"
request: "1"
- name: "example.com/bar"
request: "1"
- name: "example.com/baz"
request: "1"
- name: "example.com/qux"
request: "1"
- name: "example.com/quux"
request: "1"
expectedError: 'spec.metricsServerConfig.resources: Too many: 11: must have at most 10 items'
Loading