Skip to content

Conversation

vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Sep 3, 2025

SPLAT-2482

Changes

  • Created new feature gate ClusterAPIMachineManagementVSphere

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 3, 2025

@vr4manta: This pull request references SPLAT-2482 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

SPLAT-2482

Changes

  • Created new feature gate ClusterAPIMachineManagementVSphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Sep 3, 2025

Hello @vr4manta! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 3, 2025

@vr4manta: This pull request references SPLAT-2482 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

SPLAT-2482

Changes

  • Created new feature gate ClusterAPIMachineManagementVSphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 3, 2025
@vr4manta
Copy link
Contributor Author

vr4manta commented Sep 3, 2025

/assign @JoelSpeed

@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2025
@JoelSpeed
Copy link
Contributor

/lgtm
/verified by existing E2Es pass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 4, 2025
@openshift-ci-robot
Copy link

@JoelSpeed: This PR has been marked as verified by existing E2Es pass.

In response to this:

/lgtm
/verified by existing E2Es pass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Sep 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, JoelSpeed, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2025
@vr4manta
Copy link
Contributor Author

vr4manta commented Sep 4, 2025

/label acknowledge-critical-fixes-only
Email stating label is being removed was sent. Doing this just in case it doesn't auto refresh.

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Sep 4, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a30da32 and 2 for PR HEAD fc52f6e in total

@vr4manta
Copy link
Contributor Author

vr4manta commented Sep 5, 2025

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a30da32 and 2 for PR HEAD fc52f6e in total

Copy link
Contributor

openshift-ci bot commented Sep 5, 2025

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-hypershift-conformance fc52f6e link unknown /test e2e-aws-ovn-hypershift-conformance
ci/prow/e2e-aws-ovn-techpreview fc52f6e link unknown /test e2e-aws-ovn-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants