apiservers.config.openshift.io: remove spec.tlsSecurityProfile GoDoc caveats #2467
Conversation
|
Hello @joelanford! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/M
config/v1/types_apiserver.go
Outdated
| // If unset, a default (which may change between releases) is chosen. Note that only Old, | ||
| // Intermediate and Custom profiles are currently supported, and the maximum available | ||
| // minTLSVersion is VersionTLS12. | ||
| // If unset, a default (which may change between releases) is chosen. |
There was a problem hiding this comment.
We have standard verbiage for this behaviour, would normally read
When omitted, this means no opinion and the platform is left to choose a reasonable default, which is subject to change over time.
The current default is ...
…caveats The apiserver component was updated in OCP 4.19 to support the Modern TLS profile and TLS 1.3 Signed-off-by: Joe Lanford <[email protected]>
joelanford
force-pushed
the
tls-security-profile-doc-fix
branch
from
f641f96 to
2371796
Compare
|
@joelanford: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
The apiserver component was updated in OCP 4.19 to support the Modern TLS profile and TLS 1.3.