Skip to content

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Feb 25, 2019

Drop e2e tests in favour of using shared pkg
See:
openshift/cluster-api-provider-aws#168
openshift/machine-api-operator#219

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: enxebre

If they are not already assigned, you can assign the PR to them by writing /assign @enxebre in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 25, 2019
@enxebre
Copy link
Member Author

enxebre commented Feb 25, 2019

cc @bison @frobware @ingvagabund

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 25, 2019

@enxebre: The following tests failed for commit a887240, say /retest to rerun them:

Test name Details Rerun command
ci/jenkins/e2e link /test e2e
ci/prow/e2e-aws-operator link /test e2e-aws-operator

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre
Copy link
Member Author

enxebre commented Feb 25, 2019

@ingvagabund we might want to just disable jenkins/e2e. Once we align all repos to consume the common pkg you can renable as you evolve the tests implementation

@openshift-ci-robot
Copy link
Contributor

@enxebre: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2019
@ingvagabund
Copy link
Member

Closing in favor of #60. @enxebre thanks for the heads up.

@ingvagabund ingvagabund closed this Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants