ETCD-179: Bug 1931658: render: refactor scaling strategies #547

hexfusion · 2021-02-24T23:56:35Z

Currently, the bootstrap in place used with SNO adds an annotation alpha.installer.openshift.io/etcd-bootstrap which is intended to be used by the cluster to communicate with the bootstrap etcd instance. But bootstrap in place means that the bootstrap node will never be visible. The result is the cluster never pivots from the bootstrap node endpoint which is not expected. This change fixes that problem by adding the BootstrapInPlaceStrategy which omits that annotation.

refactor scaling strategies and add BootstrapInPlaceStrategy
add unit tests

marun · 2021-02-25T02:19:55Z

Why is it desirable to switch to defining the manifests in code? Is there a limitation of template substitution that suggests this change?

hexfusion · 2021-02-25T17:53:19Z

Why is it desirable to switch to defining the manifests in code? Is there a limitation of template substitution that suggests this change?

In the case of conditional changes against the resource using the raw object seems more natural vs rendering template variables with conditional logic. We could use a base object and append then rewrite to disk but it feels strange.

openshift-ci-robot · 2021-02-25T21:08:16Z

@hexfusion: This pull request references Bugzilla bug 1931658, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1931658: render: refactor scaling strategies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-02-25T21:11:20Z

@hexfusion: This pull request references Bugzilla bug 1931658, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1931658: render: refactor scaling strategies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hexfusion · 2021-02-25T22:21:34Z

/test e2e-metal-single-node-live-iso
/test e2e-aws-single-node

hexfusion · 2021-02-25T22:22:53Z

/hold for sno tests

hexfusion · 2021-02-25T22:35:09Z

Multi-AZ Clusters should spread the pods of a replication controller across zones

agnostic fail looks like https://bugzilla.redhat.com/show_bug.cgi?id=1929389

hexfusion · 2021-02-26T03:11:52Z

/test e2e-agnostic

hexfusion · 2021-02-26T03:15:33Z

e2e-aws-single-node

This test is not setting the bootstrapInPlace[1] in the install-config.

[1] https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-etcd-operator/547/pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-single-node/1365064469167738880/artifacts/e2e-aws-single-node/gather-extra/artifacts/configmaps.json

cc @romfreiman @tsorya

marun

/lgtm

Squash for merge?

bindata/bootkube/manifests/00_etcd-endpoints-cm.yaml

pkg/cmd/render/render_test.go

bindata/bootkube/manifests/00_etcd-endpoints-cm.yaml

romfreiman · 2021-02-26T12:19:10Z

e2e-aws-single-node

This test is not setting the bootstrapInPlace[1] in the install-config.

[1] https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-etcd-operator/547/pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-single-node/1365064469167738880/artifacts/e2e-aws-single-node/gather-extra/artifacts/configmaps.json

cc @romfreiman @tsorya

Right. It uses bootstrap vm on aws.
Bootstrap in place is used only with the e2e-metal-live-iso test

pkg/cmd/render/render.go

hexfusion · 2021-03-16T03:16:11Z

/hold cancel

hexfusion · 2021-03-16T04:01:14Z

infra
/retest

bindata/bootkube/manifests/00_etcd-endpoints-cm.yaml

pkg/cmd/render/render.go

pkg/cmd/render/render_test.go

hexfusion · 2021-03-16T20:02:21Z

added fixup

hexfusion · 2021-03-17T13:39:22Z

rebased ready for review

hexfusion · 2021-03-17T18:41:38Z

/retest

romfreiman · 2021-03-17T20:05:41Z

/test e2e-metal-single-node-live-iso

marun

/lgtm

pkg/cmd/render/render.go

Signed-off-by: Sam Batschelet <[email protected]>

hexfusion · 2021-03-18T12:05:36Z

/retest

marun · 2021-03-18T13:34:24Z

/lgtm

openshift-ci-robot · 2021-03-18T13:34:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, marun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [hexfusion]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hexfusion · 2021-03-19T01:02:31Z

/retest

openshift-bot · 2021-03-21T06:35:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-03-21T08:26:00Z

@hexfusion: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-single-node	`efda532`	link	`/test e2e-aws-single-node`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-03-21T08:58:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-03-21T12:04:59Z

@hexfusion: All pull requests linked via external trackers have merged:

openshift/cluster-etcd-operator#547

Bugzilla bug 1931658 has been moved to the MODIFIED state.

In response to this:

Bug 1931658: render: refactor scaling strategies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2021

openshift-ci-robot requested review from marun and retroflexer February 24, 2021 23:56

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2021

hexfusion force-pushed the sno-skip-bootstrap-endpoint branch 2 times, most recently from ec84b3b to c799473 Compare February 25, 2021 17:48

hexfusion changed the title ~~[wip] render: refactor scaling strategies~~ render: refactor scaling strategies Feb 25, 2021

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2021

hexfusion force-pushed the sno-skip-bootstrap-endpoint branch 3 times, most recently from 6f728c5 to aa330ca Compare February 25, 2021 20:07

hexfusion changed the title ~~render: refactor scaling strategies~~ Bug 1931658: render: refactor scaling strategies Feb 25, 2021

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 25, 2021

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2021

marun reviewed Feb 26, 2021

View reviewed changes

openshift-ci-robot assigned marun Feb 26, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2021

tsorya reviewed Mar 2, 2021

View reviewed changes

pkg/cmd/render/render.go Outdated Show resolved Hide resolved

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2021

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2021

hexfusion force-pushed the sno-skip-bootstrap-endpoint branch from df6f35c to 7ead1a3 Compare March 16, 2021 03:22

marun reviewed Mar 16, 2021

View reviewed changes

hexfusion force-pushed the sno-skip-bootstrap-endpoint branch 3 times, most recently from 18ce572 to 37903cd Compare March 17, 2021 13:38

hexfusion force-pushed the sno-skip-bootstrap-endpoint branch from 37903cd to 26c8f02 Compare March 17, 2021 13:53

marun reviewed Mar 17, 2021

View reviewed changes

pkg/cmd/render/render.go Outdated Show resolved Hide resolved

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2021

render: refactor scaling strategies

20c80c5

Signed-off-by: Sam Batschelet <[email protected]>

hexfusion force-pushed the sno-skip-bootstrap-endpoint branch from 26c8f02 to 20c80c5 Compare March 18, 2021 01:27

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2021

openshift-merge-robot merged commit 05079e3 into openshift:master Mar 21, 2021

hexfusion changed the title ~~Bug 1931658: render: refactor scaling strategies~~ ETCD-179: Bug 1931658: render: refactor scaling strategies Mar 22, 2021

jaypoulz mentioned this pull request Mar 6, 2025

OCPEDGE-1500: Added scaling strategies for TNF #1396

Merged

ETCD-179: Bug 1931658: render: refactor scaling strategies #547

ETCD-179: Bug 1931658: render: refactor scaling strategies #547

Uh oh!

Conversation

hexfusion commented Feb 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marun commented Feb 25, 2021

Uh oh!

hexfusion commented Feb 25, 2021

Uh oh!

openshift-ci-robot commented Feb 25, 2021

Uh oh!

openshift-ci-robot commented Feb 25, 2021

Uh oh!

hexfusion commented Feb 25, 2021

Uh oh!

hexfusion commented Feb 25, 2021

Uh oh!

hexfusion commented Feb 25, 2021

Uh oh!

hexfusion commented Feb 26, 2021

Uh oh!

hexfusion commented Feb 26, 2021

Uh oh!

marun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

romfreiman commented Feb 26, 2021

Uh oh!

Uh oh!

hexfusion commented Mar 16, 2021

Uh oh!

hexfusion commented Mar 16, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hexfusion commented Mar 16, 2021

Uh oh!

hexfusion commented Mar 17, 2021

Uh oh!

hexfusion commented Mar 17, 2021

Uh oh!

romfreiman commented Mar 17, 2021

Uh oh!

marun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hexfusion commented Mar 18, 2021

Uh oh!

marun commented Mar 18, 2021

Uh oh!

openshift-ci-robot commented Mar 18, 2021

Uh oh!

hexfusion commented Mar 19, 2021

Uh oh!

openshift-bot commented Mar 21, 2021

Uh oh!

openshift-ci bot commented Mar 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Mar 21, 2021

Uh oh!

openshift-ci-robot commented Mar 21, 2021

Uh oh!

Uh oh!

hexfusion commented Feb 24, 2021 •

edited

Loading

openshift-ci bot commented Mar 21, 2021 •

edited

Loading