[release-4.12] OCPBUGS-14454, OCPBUGS-14455: Handle mTLS CRLs, and fix accidental CRL duplication #941

rfredette · 2023-06-01T23:15:27Z

Manual cherry pick & squash of #939

Leave a stub of the CRL controller to clean up any existing configmaps. The stub controller will need to be removed in a future release

Use cluster-wide proxy for CRL downloads when available

Add a test with several test cases to test CRL management, and a test to test CRL updates

Leave a stub of the CRL controller to clean up any existing configmaps. The stub controller will need to be removed in a future release Use cluster-wide proxy for CRL downloads when available Add a test with several test cases to test CRL management, and a test to test CRL updates

openshift-ci-robot · 2023-06-01T23:15:32Z

@rfredette: This pull request references Jira Issue OCPBUGS-14455, which is invalid:

expected Jira Issue OCPBUGS-14455 to depend on a bug targeting a version in 4.13.0, 4.13.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Manual cherry pick & squash of #939

Leave a stub of the CRL controller to clean up any existing configmaps. The stub controller will need to be removed in a future release

Use cluster-wide proxy for CRL downloads when available

Add a test with several test cases to test CRL management, and a test to test CRL updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

frobware · 2023-06-02T15:48:20Z

=== CONT  TestAll/parallel/TestMTLSWithCRLs/certificate-distributes-its-own-crl
    client_tls_test.go:987: exec ["cat" "/var/lib/haproxy/mtls/latest/crls.pem"] failed. error: command terminated with exit code 1
        stdout:
        
        stderr:
        cat: /var/lib/haproxy/mtls/latest/crls.pem: No such file or directory

This PR (and test) depends on openshift/router#491.

frobware · 2023-06-02T15:48:27Z

/retest

frobware · 2023-06-02T15:51:22Z

/lgtm
/approve
/hold
openshift/router#491 needs to merge first.

openshift-ci · 2023-06-02T15:52:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [frobware]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Miciah · 2023-06-05T21:02:01Z

/label backport-risk-assessed

lihongan · 2023-06-06T02:44:16Z

/label cherry-pick-approved

lihongan · 2023-06-07T07:19:29Z

/jira refresh

openshift-ci-robot · 2023-06-07T07:19:33Z

@lihongan: This pull request references Jira Issue OCPBUGS-14455, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.z) matches configured target version for branch (4.12.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-13964 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-13964 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
bug has dependents

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lihongan · 2023-06-07T07:24:13Z

/unhold
since openshift/router#491 get merged

lihongan · 2023-06-07T07:25:23Z

/retest-required

frobware · 2023-06-07T09:37:28Z

"fail [github.com/openshift/origin/test/extended/util/disruption/backend_sampler_tester.go:185]: Jun 7 09:14:02.510: disruption/service-load-balancer-with-pdb connection/new was unreachable during disruption: for at least 20s of 1h10m14s (maxAllowed=19s)"

/test e2e-aws-ovn-upgrade

openshift-ci-robot · 2023-06-07T09:40:37Z

/retest-required

Remaining retests: 0 against base HEAD 21c38d5 and 2 for PR HEAD 6ecfaba in total

frobware · 2023-06-07T09:43:09Z

e2e-aws-operator - Although TestAWSELBConnectionIdleTimeout failed which is bug https://issues.redhat.com/browse/OCPBUGS-13810, so did the new mTLS tests:

        --- FAIL: TestAll/parallel/TestClientTLS (119.12s)
        --- FAIL: TestAll/parallel/TestCRLUpdate (357.86s)
            --- FAIL: TestAll/parallel/TestCRLUpdate/certificate-distributes-its-own-crl (89.80s)
            --- FAIL: TestAll/parallel/TestCRLUpdate/certificate-distributes-its-signers-crl (89.79s)
            --- FAIL: TestAll/parallel/TestCRLUpdate/certificate-distributes-its-signers-crl-with-workaround (89.26s)
            --- FAIL: TestAll/parallel/TestCRLUpdate/many-CAs-with-signers-crl-workaround (88.98s)
        --- FAIL: TestAll/parallel/TestMTLSWithCRLs (486.06s)
            --- FAIL: TestAll/parallel/TestMTLSWithCRLs/certificate-distributes-its-own-crl (98.32s)
            --- FAIL: TestAll/parallel/TestMTLSWithCRLs/certificate-distributes-its-signers-crl (93.30s)
            --- FAIL: TestAll/parallel/TestMTLSWithCRLs/certificate-distributes-its-signers-crl-with-workaround (94.26s)
            --- FAIL: TestAll/parallel/TestMTLSWithCRLs/large-crl (94.71s)
            --- FAIL: TestAll/parallel/TestMTLSWithCRLs/multiple-intermediate-ca (95.40s)

/test e2e-aws-operator

frobware · 2023-06-07T10:11:47Z

/test all

frobware · 2023-06-07T10:43:58Z

e2e-aws-ovn-upgrade job failed after 4m28s.

/test e2e-aws-ovn-upgrade

frobware · 2023-06-07T10:44:57Z

e2e-aws-operator - job failed after 9m18s.

/test e2e-aws-operator

frobware · 2023-06-07T12:32:42Z

/test e2e-aws-operator

openshift-ci-robot · 2023-06-07T14:53:59Z

/retest-required

Remaining retests: 0 against base HEAD 21c38d5 and 2 for PR HEAD 6ecfaba in total

frobware · 2023-06-07T18:06:56Z

    --- FAIL: TestAll/parallel/TestClientTLS (123.26s)

/test e2e-aws-operator

rfredette · 2023-06-07T20:15:59Z

         --- FAIL: TestAll/parallel/TestAWSELBConnectionIdleTimeout (406.29s) 
...
         --- FAIL: TestAll/parallel/TestClientTLS (117.61s)

TestAWSELBConnectionIdleTimeout has passed in earlier runs, so it seems to be the flake from https://issues.redhat.com//browse/OCPBUGS-13810 . Likely TestClientTLS is a flake as well (fixed in #904 on the master branch), but since it's actually related to the code in this PR, I don't yet feel confident in that diagnosis.

/retest

rfredette · 2023-06-07T21:12:49Z

I cherry-picked #904 onto these changes and opened #945 to test, and while e2e-aws-operator failed must-gather, the actual test suite passed (prow isn't showing the test suite logs, but they are in the artifacts here). Since the only difference between this and #945 is the TestClientTLS fix, I'm confident that the TestClientTLS failures are unrelated to the changes in this PR.

Miciah · 2023-06-07T21:46:14Z

e2e-aws-operator failed again on TestAWSELBConnectionIdleTimeout and TestClientTLS.
/override ci/prow/e2e-aws-operator
based on #941 (comment).

openshift-ci · 2023-06-07T21:46:40Z

@Miciah: Overrode contexts on behalf of Miciah: ci/prow/e2e-aws-operator

In response to this:

e2e-aws-operator failed again on TestAWSELBConnectionIdleTimeout and TestClientTLS.
/override ci/prow/e2e-aws-operator
based on #941 (comment).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-06-07T21:46:42Z

@rfredette: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-operator	`6ecfaba`	link	true	`/test e2e-aws-operator`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-06-07T21:50:52Z

@rfredette: Jira Issue OCPBUGS-14455: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14455 has been moved to the MODIFIED state.

In response to this:

Manual cherry pick & squash of #939

Leave a stub of the CRL controller to clean up any existing configmaps. The stub controller will need to be removed in a future release

Use cluster-wide proxy for CRL downloads when available

Add a test with several test cases to test CRL management, and a test to test CRL updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot · 2023-06-08T06:31:33Z

Fix included in accepted release 4.12.0-0.nightly-2023-06-07-221552

openshift-ci bot requested review from candita and miheer June 1, 2023 23:16

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2023

openshift-ci bot assigned frobware Jun 2, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2023

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 5, 2023

openshift-ci bot assigned lihongan, melvinjoseph86 and ShudiLi Jun 5, 2023

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 6, 2023

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 7, 2023

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 7, 2023

openshift-ci bot requested a review from lihongan June 7, 2023 07:19

openshift-ci-robot mentioned this pull request Jun 7, 2023

[release-4.12] OCPBUGS-14454, OCPBUGS-14455: Handle mTLS CRLs, and fix accidental CRL duplication openshift/router#491

Merged

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2023

rfredette mentioned this pull request Jun 7, 2023

[release-4.12] WIP: Handle mTLS CRLs, and fix accidental CRL duplication with TestClientTLS Fix #945

Closed

openshift-merge-robot merged commit 37c11f6 into openshift:release-4.12 Jun 7, 2023

[release-4.12] OCPBUGS-14454, OCPBUGS-14455: Handle mTLS CRLs, and fix accidental CRL duplication #941

[release-4.12] OCPBUGS-14454, OCPBUGS-14455: Handle mTLS CRLs, and fix accidental CRL duplication #941

Uh oh!

Conversation

rfredette commented Jun 1, 2023

Uh oh!

openshift-ci-robot commented Jun 1, 2023

Uh oh!

frobware commented Jun 2, 2023

Uh oh!

frobware commented Jun 2, 2023

Uh oh!

frobware commented Jun 2, 2023

Uh oh!

openshift-ci bot commented Jun 2, 2023

Uh oh!

Miciah commented Jun 5, 2023

Uh oh!

lihongan commented Jun 6, 2023

Uh oh!

lihongan commented Jun 7, 2023

Uh oh!

openshift-ci-robot commented Jun 7, 2023

Uh oh!

lihongan commented Jun 7, 2023

Uh oh!

lihongan commented Jun 7, 2023

Uh oh!

frobware commented Jun 7, 2023

Uh oh!

openshift-ci-robot commented Jun 7, 2023

Uh oh!

frobware commented Jun 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

frobware commented Jun 7, 2023

Uh oh!

frobware commented Jun 7, 2023

Uh oh!

frobware commented Jun 7, 2023

Uh oh!

frobware commented Jun 7, 2023

Uh oh!

openshift-ci-robot commented Jun 7, 2023

Uh oh!

frobware commented Jun 7, 2023

Uh oh!

rfredette commented Jun 7, 2023

Uh oh!

rfredette commented Jun 7, 2023

Uh oh!

Miciah commented Jun 7, 2023

Uh oh!

openshift-ci bot commented Jun 7, 2023

Uh oh!

openshift-ci bot commented Jun 7, 2023

Uh oh!

openshift-ci-robot commented Jun 7, 2023

Uh oh!

openshift-merge-robot commented Jun 8, 2023

Uh oh!

Uh oh!

frobware commented Jun 7, 2023 •

edited

Loading