Skip to content

Conversation

sjenning
Copy link
Contributor

@smarterclayton @brancz

follow on to my previous PR to make components run as Burstable, without limits

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sjenning
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: s-urbaniak

If they are not already assigned, you can assign the PR to them by writing /assign @s-urbaniak in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 22, 2019
@sjenning
Copy link
Contributor Author

ugh, i did it again. these are generated files that i can't find the source for.

@sjenning
Copy link
Contributor Author

doing this in openshift/prometheus-operator#20

@sjenning sjenning closed this Jan 22, 2019
@squat
Copy link
Contributor

squat commented Jan 22, 2019

@sjenning this one is a little more tricky :p
These manifests are likewise all generated from jsonnet, however they come mostly from kube-prometheus, a distribution of monitoring components that we put together and are a dependency of this project [0]. The correct way to do this would be to write a mixin that removes limits for any object used in cluster monitoring operator. (We don’t want to remove the limits upstream in the kube-prometheus distro and other projects we are importing as they have valid use cases for limits). Please let me know if you need any help or want me to take over this and I can make a PR tomorrow.

[0]
https://github.com/openshift/cluster-monitoring-operator/blob/master/jsonnet/main.jsonnet#L1

@squat
Copy link
Contributor

squat commented Jan 22, 2019

Note: kube-prometheus is being imported from the upstream repo, not the openshift fork
https://github.com/openshift/cluster-monitoring-operator/blob/master/jsonnet/jsonnetfile.json#L7

@squat
Copy link
Contributor

squat commented Feb 27, 2019

finished this in #273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants