Skip to content

Conversation

dkhater-redhat
Copy link

Recently we added mcd_local_unsupported_packages metric in MCO openshift/machine-config-operator#4614 which we would like to get added to telemetry as well.

Copy link
Contributor

openshift-ci bot commented Aug 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dkhater-redhat
Once this PR has been reviewed and has the lgtm label, please assign marioferh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dkhater-redhat dkhater-redhat changed the title add mcd_local_unsupported_packages metric from MCO to telemetry OCPBUGS-60161: Add mcd_local_unsupported_packages metric from MCO to telemetry Aug 5, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 5, 2025
@openshift-ci-robot
Copy link
Contributor

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-60161, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Recently we added mcd_local_unsupported_packages metric in MCO openshift/machine-config-operator#4614 which we would like to get added to telemetry as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@simonpasquier
Copy link
Contributor

We recommend creating a recording rule in MCO to filter away unneeded labels:
https://rhobs-handbook.netlify.app/products/openshiftmonitoring/telemetry.md/#configure-recording-rules

We also ask for a formal Jira ticket to get approval from our side. Can you create one as described in https://rhobs-handbook.netlify.app/products/openshiftmonitoring/telemetry.md/#request-approval?

@dkhater-redhat
Copy link
Author

yes wil do. thank you!

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 11, 2025
@dkhater-redhat
Copy link
Author

@dkhater-redhat
Copy link
Author

updated the metric name to reflect the recording rule change

@dkhater-redhat dkhater-redhat force-pushed the add-mco-telemetry branch 4 times, most recently from 119c86e to 82f8193 Compare August 12, 2025 14:58
@dkhater-redhat
Copy link
Author

/test e2e-aws-ovn

Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
we need formal agreement on https://issues.redhat.com/browse/MON-4316

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2025
Copy link
Contributor

openshift-ci bot commented Aug 18, 2025

@dkhater-redhat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift-conformance 409b6ef link true /test e2e-hypershift-conformance
ci/prow/generate 409b6ef link true /test generate
ci/prow/images 409b6ef link true /test images
ci/prow/okd-scos-e2e-aws-ovn 409b6ef link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-techpreview 409b6ef link true /test e2e-aws-ovn-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants