-
Notifications
You must be signed in to change notification settings - Fork 376
OCPBUGS-60161: Add mcd_local_unsupported_packages metric from MCO to telemetry #2638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dkhater-redhat The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dkhater-redhat: This pull request references Jira Issue OCPBUGS-60161, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
60f8c42
to
48d25f9
Compare
We recommend creating a recording rule in MCO to filter away unneeded labels: We also ask for a formal Jira ticket to get approval from our side. Can you create one as described in https://rhobs-handbook.netlify.app/products/openshiftmonitoring/telemetry.md/#request-approval? |
yes wil do. thank you! |
48d25f9
to
909ce8d
Compare
909ce8d
to
12b9e31
Compare
updated the metric name to reflect the recording rule change |
119c86e
to
82f8193
Compare
/test e2e-aws-ovn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
we need formal agreement on https://issues.redhat.com/browse/MON-4316
82f8193
to
7f76936
Compare
7f76936
to
409b6ef
Compare
@dkhater-redhat: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Recently we added mcd_local_unsupported_packages metric in MCO openshift/machine-config-operator#4614 which we would like to get added to telemetry as well.