NO-JIRA: chore: bump jsonnet dependencies #2649
Conversation
openshift-ci
bot
added
the
approved
simonpasquier
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@simonpasquier: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/skip |
simonpasquier
force-pushed
the
bump-jsonnet-deps
branch
from
a84ea2e to
4ae66f1
Compare
|
/skip |
| @@ -32,9 +32,10 @@ spec: | |||
| automountServiceAccountToken: true | |||
| containers: | |||
| - args: | |||
| - --web.listen-address=127.0.0.1:9100 | |||
There was a problem hiding this comment.
I agree, using the same port on different interfaces can confusing, plus a pod has plenty of them
| @@ -278,6 +278,15 @@ spec: | |||
| for: 15m | |||
| labels: | |||
| severity: warning | |||
| - alert: NodeSystemdServiceCrashlooping | |||
There was a problem hiding this comment.
we'd need a ticket to understand and add a runbook for this one.
There was a problem hiding this comment.
I've opted for removing the alerting rule: the systemd collector isn't enabled by default + when it is, users can define their own AlertingRule custom resource (they probably do already).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: machine424, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel removing the hold since we're in |
openshift-ci
bot
removed
the
do-not-merge/hold
This change updates jsonnet dependencies to their latest versions. In particular, it freezes the node_exporter and Prometheus dashboards to the latest versions supporting Grafana 11. From now on, these dashboards will no longer receive updates from the upstream mixins (until we migrate to the upstream Perses dashboards). Signed-off-by: Simon Pasquier <[email protected]>
simonpasquier
force-pushed
the
bump-jsonnet-deps
branch
from
4ae66f1 to
a176694
Compare
|
New changes are detected. LGTM label has been removed. |
|
/retest-required |
1 similar comment
|
/retest-required |
|
@simonpasquier: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This change updates jsonnet dependencies to their latest versions. In particular, it freezes the node_exporter and Prometheus dashboards to the latest versions supporting Grafana 11. From now on, these dashboards will no longer receive updates from the upstream mixins (until we migrate to the upstream Perses dashboards).
The PR can wait after the 4.20 branch cut