Skip to content

Conversation

gabemontero
Copy link
Contributor

/assign @bparees

again included pick from other in flight PRs to minimize rebase pain

last commit is the one ... also there were some openshift/library updates; picked those up while testing the change to the library sync script

@xiuwang FYI ... another cfg change has come down ... leaving the arch field in for future use, but removing the ppc choice since that is now NOT on the immediate horizon (we'll see what happens in a year after the acquisition)

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2019
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 15, 2019
@bparees
Copy link
Contributor

bparees commented Feb 15, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bparees,gabemontero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gabemontero
Copy link
Contributor Author

@xiuwang unless you prefer Jira, I'll open a bugzilla to track you picking up this change, updating test cases as needed

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. labels Feb 16, 2019
@openshift-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@gabemontero gabemontero added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2019
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 16, 2019
@gabemontero
Copy link
Contributor Author

rebase after remove-okd-centos pushed

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees
Copy link
Contributor

bparees commented Feb 16, 2019

/retest

2 similar comments
@bparees
Copy link
Contributor

bparees commented Feb 16, 2019

/retest

@bparees
Copy link
Contributor

bparees commented Feb 16, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6936243 into openshift:master Feb 16, 2019
@gabemontero gabemontero deleted the remove-ppc branch February 16, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants