Skip to content

Bug 2042649: Bump helm to v3.7.1 #10469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2022
Merged

Bug 2042649: Bump helm to v3.7.1 #10469

merged 1 commit into from
Jan 20, 2022

Conversation

dperaza4dustbit
Copy link
Contributor

Moving helm dependency to 3.7.1

Signed-off-by: David Peraza [email protected]

@openshift-ci openshift-ci bot requested review from jhadvig and rhamilto November 16, 2021 02:49
@openshift-ci openshift-ci bot added component/backend Related to backend kind/dependency-change Categorizes issue or PR as related to changing dependencies labels Nov 16, 2021
@zonggen
Copy link

zonggen commented Nov 16, 2021 •
edited
Loading

/lgtm

@dperaza4dustbit
Copy link
Contributor Author

/retest

@dperaza4dustbit
Copy link
Contributor Author

/test e2e-gcp-console

1 similar comment
@dperaza4dustbit
Copy link
Contributor Author

/test e2e-gcp-console

@dperaza4dustbit
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2021
@dperaza4dustbit dperaza4dustbit force-pushed the bump_helm_dependnecy_3.7.1 branch from 5147150 to a522f9c Compare December 6, 2021 15:14
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2021
@dperaza4dustbit dperaza4dustbit force-pushed the bump_helm_dependnecy_3.7.1 branch 2 times, most recently from 6798770 to cf0d814 Compare December 9, 2021 04:22
@dperaza4dustbit
Copy link
Contributor Author

dperaza4dustbit commented Dec 9, 2021 •
edited
Loading

Having issues with conflicts between github.com/deislabs/oras and latest github.com/containerd/containerd pulled by helm v3.7.1 packaged. Helm v3.7.1 is now using oras.land/oras-go instead of helm 3.6.2 was using github.com/deislabs/oras. Had to make a manual change to vendor file to get it to build. This is a test run for that. But will like to investigate other solutions to avoid manual change that will be erase by next go mod vendor run.

@christianvogt
Copy link
Contributor

fyi @jhadvig @spadgett

@jhadvig
Copy link
Member

jhadvig commented Dec 9, 2021

We should avoid manually changing vendor files.
@dperaza4dustbit what conflict are you getting ?

@dperaza4dustbit
Copy link
Contributor Author

Coordinating with @johnmcollier and team on the devfile side to move the oras dependency to match helm to be able to move this one forward. Issue created here: devfile/api#708

@dperaza4dustbit
Bump helm to v3.7.1
6d8fc5d 
Moving helm dependency to 3.7.1

Signed-off-by: David Peraza <[email protected]>
@dperaza4dustbit dperaza4dustbit force-pushed the bump_helm_dependnecy_3.7.1 branch from cf0d814 to 6d8fc5d Compare January 14, 2022 16:15
@dperaza4dustbit
Copy link
Contributor Author

/assign @jhadvig

@dperaza4dustbit
Copy link
Contributor Author

/restest

@dperaza4dustbit
Copy link
Contributor Author

/retest

2 similar comments
@rohitkrai03
Copy link
Contributor

/retest

@dperaza4dustbit
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2022 •
edited
Loading

@dperaza4dustbit: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp a522f9c1d552e34386ec77169ce306e4beb4932e link true /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dperaza4dustbit
Copy link
Contributor Author

/retest

jhadvig
jhadvig approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2022
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2022
@dperaza4dustbit dperaza4dustbit changed the title Bump helm to v3.7.1 Bug 2042649: Bump helm to v3.7.1 Jan 19, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2022

@dperaza4dustbit: This pull request references Bugzilla bug 2042649, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 2042649: Bump helm to v3.7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yapei January 19, 2022 20:40
@zonggen
Copy link

zonggen commented Jan 19, 2022

/lgtm

@zonggen
Copy link

zonggen commented Jan 19, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dperaza4dustbit, jhadvig, zonggen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit fc92270 into openshift:master Jan 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2022

@dperaza4dustbit: All pull requests linked via external trackers have merged:

Bugzilla bug 2042649 has been moved to the MODIFIED state.

In response to this:

Bug 2042649: Bump helm to v3.7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@rhamilto rhamilto Awaiting requested review from rhamilto

@yapei yapei Awaiting requested review from yapei

Assignees

@jhadvig jhadvig

@zonggen zonggen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/backend Related to backend kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dperaza4dustbit @zonggen @christianvogt @jhadvig @rohitkrai03 @openshift-merge-robot