Bug 1961336: Remove the broken Devfile Sample for BuildConfigs #8948
Conversation
openshift-ci
bot
added
the
bugzilla/severity-medium
|
@andrewballantyne: This pull request references Bugzilla bug 1961336, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
/cherry-pick release-4.7 |
|
@andrewballantyne: once the present PR merges, I will cherry-pick it on top of release-4.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
component/shared
|
/lgtm verified the changes, works as expected. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, invincibleJai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@andrewballantyne: All pull requests linked via external trackers have merged: Bugzilla bug 1961336 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@andrewballantyne: new pull request created: #8956 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Analysis / Root cause:
During 4.7's #7299 there was a partial implementation of a sample that just didn't work.
Solution Description:
Remove it. It was never part of the design and slipped through during the work handoff in 4.7.
Screen shots / Gifs for design review:
Before:
After:
Test setup:
Dev Perspective => Builds => Create BuildConfig => "Samples" sidebar tab.
Browser conformance: