Skip to content

STOR-2392: Rebase to upstream v8.3.0 for OCP 4.20 #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 50 commits into from
Jul 16, 2025

Conversation

mjnagel and others added 30 commits September 23, 2024 10:43
Updates commands for better readability, adding code syntax and denoting how to use remote kustomization.
04965932 Merge pull request kubernetes-csi#268 from huww98/cloudbuild
119aee1f Merge pull request kubernetes-csi#266 from jsafrane/bump-sanity-5.3.1
0ae5e52d Update cloudbuild image with go 1.21+
406a79ac Merge pull request kubernetes-csi#267 from huww98/gomodcache
9cec273d Set GOMODCACHE to avoid re-download toolchain
98f23071 Merge pull request kubernetes-csi#260 from TerryHowe/update-csi-driver-version
e9d8712d Merge pull request kubernetes-csi#259 from stmcginnis/deprecated-kind-kube-root
faf79ff6 Remove --kube-root deprecated kind argument
734c2b95 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch
43bde065 Bump csi-sanity to 5.3.1
f95c855b Merge pull request kubernetes-csi#262 from huww98/golang-toolchain
3c8d966f Treat main branch as equivalent to master branch
6b05f0fc use new GOTOOLCHAIN env to manage go version
18b6ac6d chore: update CSI driver version to 1.15

git-subtree-dir: release-tools
git-subtree-split: 04965932661b6e62709dcdbb9c25da528bac2605
docs: update install commands for CRDs + snapshotter
90efb2ca5 Merge pull request kubernetes-csi#272 from andyzhangx/patch-3
9b616fec4 Bump golang to 1.23.6 to fix CVE-2024-45336, CVE-2025-22866

git-subtree-dir: release-tools
git-subtree-split: 90efb2ca59900f19eba05e65da28beda79c5bb28
Add leader election, work-queue, process, and Go runtime metrics
Update controller deployment to latest version
0a435bf98 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba3 Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34bc Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e8 Bump golang to 1.24.0
f277d561f Merge pull request kubernetes-csi#270 from carlory/update-kind-version
6dcb96a51 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 0a435bf987dd41314377818fa26a7bed006c01cd
0a435bf98 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba3 Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34bc Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e8 Bump golang to 1.24.0
f277d561f Merge pull request kubernetes-csi#270 from carlory/update-kind-version
6dcb96a51 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 0a435bf987dd41314377818fa26a7bed006c01cd
jsafrane and others added 12 commits May 22, 2025 12:44
Let syncContent() continue cleaning up VolumeSnapshotContent
(i.e. remove its finalizers) after its snapshot has been deleted from the
storage backend.

It will requeue on all errors.

Calling ctrl.updateContentInInformerCache() directly from
deleteCSISnapshotOperation() does not requeue the snapshot content on
error.
The name suggests it only updates the cache, but it also resyncs the
object. There is just only one caller, so remove the function completely.
The new -automaxprocs flag can be used to set the GOMAXPROCS
environment variable to match the configured Linux container CPU quota.
Add `-automaxprocs` flag for configuring `GOMAXPROCS`
Queue resyncs in `ShouldEnqueueContentChange`
…moval-requeue

Fix finalizer removal requeue
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 1, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 1, 2025

@dfajmon: This pull request references STOR-2392 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Issue link:
https://issues.redhat.com/browse/STOR-2392

Diff to upstream v8.3.0:
kubernetes-csi/external-snapshotter@v8.3.0...dfajmon:rebase-v8.3.0

Changes between v8.2.1 (OCP 4.19) and v8.3.0 (OCP 4.20):

Full changelogs:
https://github.com/kubernetes-csi/external-snapshotter/blob/v8.3.0/CHANGELOG/CHANGELOG-8.3.md

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jsafrane and rhrmo July 1, 2025 08:17
Copy link

openshift-ci bot commented Jul 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfajmon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2025
@dfajmon
Copy link
Author

dfajmon commented Jul 1, 2025

/retest

1 similar comment
@dfajmon
Copy link
Author

dfajmon commented Jul 4, 2025

/retest

@RomanBednar
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2025
@duanwei33
Copy link

No user-facing feature, the CI results look good, which should be sufficient for merging.
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 16, 2025

@dfajmon: This pull request references STOR-2392 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Issue link:
https://issues.redhat.com/browse/STOR-2392

Diff to upstream v8.3.0:
kubernetes-csi/external-snapshotter@v8.3.0...dfajmon:rebase-v8.3.0

Changes between v8.2.1 (OCP 4.19) and v8.3.0 (OCP 4.20):

Full changelogs:
https://github.com/kubernetes-csi/external-snapshotter/blob/v8.3.0/CHANGELOG/CHANGELOG-8.3.md

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Jul 16, 2025

@dfajmon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4260482 into openshift:master Jul 16, 2025
10 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-csi-external-snapshotter
This PR has been included in build ose-csi-external-snapshotter-container-v4.20.0-202507160714.p0.g4260482.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-csi-snapshot-controller
This PR has been included in build ose-csi-snapshot-controller-container-v4.20.0-202507160714.p0.g4260482.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.