-
Notifications
You must be signed in to change notification settings - Fork 19
OCPBUGS-25981: UPSTREAM distribution/distribution: 4190 fix: use http.DefaultTransport in S3 client #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kaovilai FYI |
ack Thanks. |
/retitle OCPBUGS-25981: UPSTREAM distribution/distribution: 4190 fix: use http.DefaultTransport in S3 client |
@mpryc: This pull request references Jira Issue OCPBUGS-25981, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@kaovilai: This pull request references Jira Issue OCPBUGS-25981, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
jira refresh |
/jira refresh |
@kaovilai: This pull request references Jira Issue OCPBUGS-25981, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@kaovilai: This pull request references Jira Issue OCPBUGS-25981, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherry-pick release-4.14 release-4.15 release-4.16 release-4.17 release-4.18 |
@kaovilai: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-4.15 |
@kaovilai: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-4.16 |
/cherry-pick release-4.17 |
@kaovilai: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@kaovilai: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-4.18 |
@kaovilai: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Great stuff, @kaovilai! Could you open a PR against openshift/image-registry, replacing this repository in go.mod so that it points to your fork that contains the changes in this PR? This repository (docker-distribution) is deployed through the openshift/image-registry, so updating the go.mod/vendor on that repo is the only way for QE to test the changes done here. Thanks! |
The mentioned changes for fixing OCPBUGS-41212 are in the release-4.14 and newer branches, so I think we should be good here. |
/unhold |
lgtm! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flavianmissi, kaovilai, mpryc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@kaovilai: This pull request references Jira Issue OCPBUGS-25981, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@kaovilai: This pull request references Jira Issue OCPBUGS-25981, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@mpryc: Jira Issue OCPBUGS-25981: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-25981 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@kaovilai: new pull request created: #47 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@kaovilai: new pull request created: #48 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@kaovilai: new pull request created: #49 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@kaovilai: new pull request created: #50 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@kaovilai: new pull request created: #51 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@mpryc: new pull request could not be created: failed to create pull request against openshift/docker-distribution#release-4.18 from head openshift-cherrypick-robot:cherry-pick-44-to-release-4.18: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-44-to-release-4.18."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
bumping docker-distribution dependency as the new version includes a few new regions. this bump also includes the changes introduced by openshift/docker-distribution#44.
Resolves: OADP-25981
Cherry-picked from: