Skip to content

Conversation

mpryc
Copy link

@mpryc mpryc commented Sep 26, 2024

Resolves: OADP-25981

Cherry-picked from:

$ git cherry-pick -m 1 dfeaad7e3bbe3bfa2d913dfe37f7f233dbf62b09

@mpryc
Copy link
Author

mpryc commented Sep 26, 2024

@kaovilai FYI

@kaovilai
Copy link
Member

ack Thanks.

@kaovilai
Copy link
Member

/retitle OCPBUGS-25981: UPSTREAM distribution/distribution: 4190 fix: use http.DefaultTransport in S3 client

@openshift-ci openshift-ci bot changed the title fix: use http.DefaultTransport in S3 client (#4190) OCPBUGS-25981: UPSTREAM distribution/distribution: 4190 fix: use http.DefaultTransport in S3 client Sep 26, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 26, 2024
@openshift-ci-robot
Copy link

@mpryc: This pull request references Jira Issue OCPBUGS-25981, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Resolves: OADP-25981

Cherry-picked from:

$ git cherry-pick -m 1 dfeaad7e3bbe3bfa2d913dfe37f7f233dbf62b09

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kaovilai
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

@kaovilai: This pull request references Jira Issue OCPBUGS-25981, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kaovilai
Copy link
Member

jira refresh

@kaovilai
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

@kaovilai: This pull request references Jira Issue OCPBUGS-25981, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kaovilai
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 26, 2024
@openshift-ci-robot
Copy link

@kaovilai: This pull request references Jira Issue OCPBUGS-25981, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wewang58

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from wewang58 September 26, 2024 13:59
@kaovilai
Copy link
Member

/cherry-pick release-4.14 release-4.15 release-4.16 release-4.17 release-4.18

@openshift-cherrypick-robot

@kaovilai: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14 release-4.15 release-4.16 release-4.17 release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kaovilai
Copy link
Member

/cherry-pick release-4.15

@openshift-cherrypick-robot

@kaovilai: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kaovilai
Copy link
Member

/cherry-pick release-4.16

@kaovilai
Copy link
Member

/cherry-pick release-4.17

@openshift-cherrypick-robot

@kaovilai: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@kaovilai: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kaovilai
Copy link
Member

/cherry-pick release-4.18

@openshift-cherrypick-robot

@kaovilai: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@flavianmissi
Copy link
Member

Great stuff, @kaovilai!

Could you open a PR against openshift/image-registry, replacing this repository in go.mod so that it points to your fork that contains the changes in this PR? This repository (docker-distribution) is deployed through the openshift/image-registry, so updating the go.mod/vendor on that repo is the only way for QE to test the changes done here.

Thanks!

@mpryc
Copy link
Author

mpryc commented Jan 15, 2025

The mentioned changes for fixing OCPBUGS-41212 are in the release-4.14 and newer branches, so I think we should be good here.

https://github.com/openshift/docker-distribution/blob/release-4.14/registry/storage/driver/s3-aws/s3.go

@mpryc
Copy link
Author

mpryc commented Jan 15, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2025
@kaovilai
Copy link
Member

lgtm!

Copy link

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, kaovilai, mpryc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kaovilai
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

@kaovilai: This pull request references Jira Issue OCPBUGS-25981, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kaovilai
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 15, 2025
@openshift-ci-robot
Copy link

@kaovilai: This pull request references Jira Issue OCPBUGS-25981, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @wewang58

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 21eefcc into openshift:master Jan 15, 2025
1 check passed
@openshift-ci-robot
Copy link

@mpryc: Jira Issue OCPBUGS-25981: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25981 has been moved to the MODIFIED state.

In response to this:

Resolves: OADP-25981

Cherry-picked from:

$ git cherry-pick -m 1 dfeaad7e3bbe3bfa2d913dfe37f7f233dbf62b09

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@kaovilai: new pull request created: #47

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@kaovilai: new pull request created: #48

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@kaovilai: new pull request created: #49

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@kaovilai: new pull request created: #50

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@kaovilai: new pull request created: #51

In response to this:

/cherry-pick release-4.14 release-4.15 release-4.16 release-4.17 release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@mpryc: new pull request could not be created: failed to create pull request against openshift/docker-distribution#release-4.18 from head openshift-cherrypick-robot:cherry-pick-44-to-release-4.18: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-44-to-release-4.18."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants