HIVE-2391: vSphere zonal support

[dlom]

xref: HIVE-2391

This PR is a re-do of #2541

[openshift-ci-robot]

@dlom: This pull request references HIVE-2391 which is a valid jira issue.

In response to this:

xref: HIVE-2391

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dlom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@dlom: This pull request references HIVE-2391 which is a valid jira issue.

In response to this:

xref: HIVE-2391

This PR is a re-do of #2541

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dlom]

xref: HIVE-2396

[codecov]

Codecov Report

❌ Patch coverage is 31.11111% with 124 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.19%. Comparing base (4929f16) to head (23e8a39).

Files with missing lines	Patch %	Lines
...om/openshift/hive/apis/hive/v1/vsphere/platform.go	0.00%	47 Missing ⚠️
pkg/clusterresource/vsphere.go	59.42%	28 Missing ⚠️
.../clusterdeployment/clusterdeployment_controller.go	0.00%	9 Missing and 1 partial ⚠️
contrib/pkg/createcluster/create.go	0.00%	9 Missing ⚠️
pkg/controller/utils/credentials.go	0.00%	9 Missing ⚠️
contrib/pkg/deprovision/vsphere.go	0.00%	8 Missing ⚠️
pkg/install/generate.go	0.00%	6 Missing ⚠️
...g/controller/clusterpool/clusterpool_controller.go	0.00%	3 Missing ⚠️
pkg/controller/machinepool/vsphereactuator.go	81.81%	1 Missing and 1 partial ⚠️
.../v1/clusterdeployment_validating_admission_hook.go	66.66%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2731      +/-   ##
==========================================
- Coverage   50.25%   50.19%   -0.06%     
==========================================
  Files         288      289       +1     
  Lines       34079    34119      +40     
==========================================
  Hits        17127    17127              
- Misses      15604    15647      +43     
+ Partials     1348     1345       -3     

Files with missing lines	Coverage Δ
...s/hive/v1/clusterpool_validating_admission_hook.go	80.85% <100.00%> (ø)
...hift/hive/apis/hive/v1/clusterdeprovision_types.go	0.00% <ø> (ø)
pkg/controller/machinepool/vsphereactuator.go	69.81% <81.81%> (-3.45%)	⬇️
.../v1/clusterdeployment_validating_admission_hook.go	86.53% <66.66%> (+0.64%)	⬆️
...g/controller/clusterpool/clusterpool_controller.go	58.26% <0.00%> (+0.21%)	⬆️
pkg/install/generate.go	45.20% <0.00%> (-0.37%)	⬇️
contrib/pkg/deprovision/vsphere.go	0.00% <0.00%> (ø)
contrib/pkg/createcluster/create.go	0.00% <0.00%> (ø)
pkg/controller/utils/credentials.go	0.00% <0.00%> (ø)
.../clusterdeployment/clusterdeployment_controller.go	65.70% <0.00%> (-0.35%)	⬇️
... and 2 more

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-ci]

@dlom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.