Skip to content

Conversation

wking
Copy link
Member

@wking wking commented Feb 26, 2019

Through 6b6b55b (#1270), following up on #1270 since we didn't end up cutting a release on top of that commit.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 26, 2019
Through 0208204 (Merge pull request openshift#1305 from
deads2k/admin-kubeconfig-2, 2019-02-25).
@wking
Copy link
Member Author

wking commented Feb 27, 2019

I've pushed fdcac06 -> 4caac53 to line up with 0208204 for:

$ oc adm release info --commits quay.io/openshift-release-dev/ocp-release:4.0.0-0.5 | grep installer
  installer                                     https://github.com/openshift/installer                                     02082043411928b66058f2ddaf97500cc393c9ac

I didn't change the diff, because I think the backing changes were minor and already covered by existing change-log entries.

@crawford
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit afce3ac into openshift:master Feb 27, 2019
@wking wking deleted the version-0.13.0 branch February 27, 2019 04:40
wking added a commit to wking/openshift-installer that referenced this pull request Feb 28, 2019
Backport 4caac53 (CHANGELOG: Document changes since 8f08508,
2019-02-26, openshift#1316), so we can build the 0.13.1 docs on top of the
0.13.0 docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants