data/aws/bootstrap: Restore global SSH access #1326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 6c10827 (Removing unused/deprecated security groups and ports, 2019-02-23, openshift#1306), we restricted master SSH access to the cluster, catching up with 6add0ab (data/aws: move the masters to the private subnets, 2019-01-10, openshift#1045). But the bootstrap node is a useful SSH bastion for debugging hung installs (until we get far enough along to tear down the bootstrap resources). This commit restores global SSH access to the bootstrap node, now that it is no longer provided by the master security group.
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/S
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
e2e-aws was not happy: But who knows, maybe they're all flakes? /retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
I noticed that I cannot ssh into the bootstrap node anymore. Ssh just blocks. And the AWS console tells me that no ssh key is associated with the node. Are you sure SSH is working right now? |
We don't use AWS Keys (docs).
No, although this change echos our journald approach, and we know that works in CI. |
Fix in flight with #1348. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 6c10827 (#1306), we restricted master SSH access to the cluster, catching up with 6add0ab (#1045). But the bootstrap node is a useful SSH bastion for debugging hung installs (until we get far enough along to tear down the bootstrap resources). This commit restores global SSH access to the bootstrap node, now that it is no longer provided by the master security group.