revision: log all changes for the latest revision #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
sttts
reviewed
Mar 1, 2019
pkg/operator/staticpod/controller/revision/revision_controller.go
Outdated
Show resolved
Hide resolved
mfojtik
force-pushed
the
revision-controller-log-changes
branch
from
95dc92b to
831a3f5
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
bertinatto
pushed a commit
to bertinatto/library-go
that referenced
this pull request
Jul 2, 2020
…-changes revision: log all changes for the latest revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we will log the JSON diff of the config/secret that caused the new revision rollout.
This should make us understand better the reason for the rollouts without spamming events to much.
Additionally, this will report all changed secrets/configs instead of reporting just one.