Skip to content

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Jul 29, 2025

No description provided.

@kyoto kyoto requested a review from jgbernalp July 29, 2025 09:35
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2025
@openshift-ci openshift-ci bot requested review from JoaoFula and joshuawilson July 29, 2025 09:35
Copy link

openshift-ci bot commented Jul 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xrajesh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2025
@kyoto kyoto force-pushed the pattern-fly-6 branch 7 times, most recently from c3d0060 to e118d41 Compare August 13, 2025 02:06
@kyoto kyoto force-pushed the pattern-fly-6 branch 4 times, most recently from d9c677c to aa43741 Compare September 2, 2025 06:54
@kyoto
Copy link
Member Author

kyoto commented Sep 2, 2025

/retest

@kyoto kyoto force-pushed the pattern-fly-6 branch 3 times, most recently from 426394b to 8e1f05b Compare September 5, 2025 10:05
@kyoto
Copy link
Member Author

kyoto commented Sep 6, 2025

/retest

Run `npx @patternfly/pf-codemods@latest . --v6 --fix`
Pass menu toggle icons to the `icon` prop instead of as children
  - This is now the recommended approach from PatternFly 6
Fix Dropdown's onSelect call
  - This now takes a string ID rather than the pod object
Run `npx @patternfly/class-name-updater . --v6 --fix`
Run `npx @patternfly/css-vars-updater . --fix`
Switch from Page to Stack for layout
Less padding is needed for the 4.19 web console layout
- Use PatternFly AI Chatbot's ChatbotHeader, MessageBar, Message &
  feedback components
- Combines all of the prompt input logic into it's own component
- Update tests
Copy link

openshift-ci bot commented Sep 7, 2025

@kyoto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants