Skip to content

Conversation

red-hat-konflux[bot]
Copy link
Contributor

@red-hat-konflux red-hat-konflux bot commented Mar 2, 2025

This PR contains the following updates:

Package Change Age Confidence
sigs.k8s.io/controller-runtime v0.20.4 -> v0.21.0 age confidence

Release Notes

kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)

v0.21.0

Compare Source

Highlights

  • Bump to Kubernetes v1.33 libraries
  • Improvements for priority queue (#​2374)
  • envtest now has an option to download envtest binaries (can be used to replace setup-envtest depending on use case)
  • Metric improvements: native histograms, all Go runtime metrics are enabled now
  • Various bug fixes
  • New reviewers: @​troy0820, @​JoelSpeed!!

⚠️ Breaking Changes

  • Bump to k8s.io/* v0.33.0 and Go 1.24 (#​3104 #​3142 #​3161 #​3204 #​3215)
  • config: Stop enabling client-side ratelimiter by default (#​3119)
    • Previous behavior can be preserved by setting QPS 20 and Burst 30 on the rest.Config
  • controller: NewUnmanaged/NewTypedUnmanaged: Stop requiring a manager (#​3141)
  • reconcile: Deprecate Result.Requeue (#​3107)

✨ New Features

  • controller: priority queue:
  • envtest: Add Environment.KubeConfig field (#​2278)
  • envtest: Add option to download envtest binaries (#​3135 #​3137)
  • events: Add IsInInitialList to TypedCreateEvent (#​3162)
  • log/zap: Enable panic log level (#​3186)
  • logging: Adopt WarningHandlerWithContext (#​3176)
  • logging: Improve logging by adopting contextual logging (#​3149)
  • metrics: Adopt native histograms (#​3165)
  • metrics: Expose all Go runtime metrics (#​3070)

🐛 Bug Fixes

  • apiutil: restmapper: Respect preferred version (#​3151)
  • builder: webhook: Fix custom path for webhook conflicts (#​3102)
  • cache: Clone maps to prevent data races when concurrently creating caches using the same options (#​3078)
  • cache: Stop accumulating lists in multi-namespace cache implementation (#​3195)
  • cache: List out of global cache when present and necessary (#​3126)
  • client: Return error if pagination is used with the cached client (#​3134)
  • controller: Support WaitForSync in TypedSyncingSource (#​3084)
  • controller: priority queue: Fix behavior of rate limit option in priorityqueue.AddWithOpts (#​3103)
  • controller: priority queue: Yet another queue_depth metric fix (#​3085)
  • controllerutil: CreateOrUpdate: Avoid panic when the MutateFn is nil (#​2828)
  • envtest: Fix nil pointer exception in Stop() (#​3153)
  • fake client: Fix data races when writing to the scheme (#​3143)
  • fake client: Use k8s.io/apimachinery/pkg/util/json to unmarshal in fake client (#​3208)
  • log/zap: Fix verbose info lost on KubeAwareEncoder.Clone (#​3209)
  • logging: controller: Use fmt.Stringer from custom source for logging (if available) (#​3068)
  • webhook: MultiMutatingHandler/MultiValidatingHandler: return warnings on webhook response (#​3223)

🌱 Others

  • Add troy0820 to reviewers (#​3099)
  • Add JoelSpeed to reviewers (#​3097)
  • client: Validate that unstructured objects don't require scheme registration (#​3138)
  • controller: Mention the SkipNameValidation option in the name validation error (#​3170)
  • docs: Clarify that controller-runtime is not a kubebuilder subproject (#​3185)
  • envtest: Export envtest.ReadCRDFiles (#​3129)
  • golangci-lint: Bump golangci-lint to v1.63.4 (#​3076)
  • golangci-lint: Bump golangci-lint to v2.1.6 (#​3187)
  • manager: Fix race in unit test (#​3150)
  • setup-envtest: Add RELEASE_TAG to show binary version with version command (#​3166)
  • setup-envtest: Fix Godoc for version.Version (#​3177)
  • tests: Fix: make test fails with make: *** [Makefile:73: test] Error 1 (#​3125)

📖 Additionally, there have been 4 contributions to our documentation. (#​3116, #​3118, #​3169, #​3181, #​3193, #​3225)

Dependencies

Added
  • github.com/klauspost/compress: v1.18.0
  • github.com/kylelemons/godebug: v1.1.0
  • github.com/planetscale/vtprotobuf: 0393e58
  • go.opentelemetry.io/auto/sdk: v1.1.0
  • gopkg.in/go-jose/go-jose.v2: v2.6.3
  • sigs.k8s.io/randfill: v1.0.0
Changed
  • cel.dev/expr: v0.18.0 → v0.19.1
  • cloud.google.com/go/compute/metadata: v0.3.0 → v0.5.0
  • github.com/cncf/xds/go: 555b57e → b4127c9
  • github.com/coreos/go-oidc: v2.2.1+incompatible → v2.3.0+incompatible
  • github.com/davecgh/go-spew: d8f796a → v1.1.1
  • github.com/envoyproxy/go-control-plane: v0.12.0 → v0.13.0
  • github.com/envoyproxy/protoc-gen-validate: v1.0.4 → v1.1.0
  • github.com/evanphx/json-patch/v5: v5.9.0 → v5.9.11
  • github.com/golang-jwt/jwt/v4: v4.5.0 → v4.5.2
  • github.com/golang/glog: v1.2.1 → v1.2.2
  • github.com/google/cel-go: v0.22.0 → v0.23.2
  • github.com/google/gnostic-models: v0.6.8 → v0.6.9
  • github.com/google/go-cmp: v0.6.0 → v0.7.0
  • github.com/gorilla/websocket: v1.5.0 → e064f32
  • github.com/grpc-ecosystem/grpc-gateway/v2: v2.20.0 → v2.24.0
  • github.com/jessevdk/go-flags: v1.4.0 → v1.6.1
  • github.com/onsi/ginkgo/v2: v2.21.0 → v2.22.0
  • github.com/onsi/gomega: v1.35.1 → v1.36.1
  • github.com/pmezard/go-difflib: 5d4384e → v1.0.0
  • github.com/prometheus/client_golang: v1.19.1 → v1.22.0
  • github.com/prometheus/common: v0.55.0 → v0.62.0
  • github.com/rogpeppe/go-internal: v1.12.0 → v1.13.1
  • github.com/stretchr/objx: v0.5.0 → v0.5.2
  • github.com/stretchr/testify: v1.9.0 → v1.10.0
  • go.etcd.io/etcd/api/v3: v3.5.16 → v3.5.21
  • go.etcd.io/etcd/client/pkg/v3: v3.5.16 → v3.5.21
  • go.etcd.io/etcd/client/v2: v2.305.16 → v2.305.21
  • go.etcd.io/etcd/client/v3: v3.5.16 → v3.5.21
  • go.etcd.io/etcd/pkg/v3: v3.5.16 → v3.5.21
  • go.etcd.io/etcd/raft/v3: v3.5.16 → v3.5.21
  • go.etcd.io/etcd/server/v3: v3.5.16 → v3.5.21
  • go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc: v0.53.0 → v0.58.0
  • go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp: v0.53.0 → v0.58.0
  • go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc: v1.27.0 → v1.33.0
  • go.opentelemetry.io/otel/exporters/otlp/otlptrace: v1.28.0 → v1.33.0
  • go.opentelemetry.io/otel/metric: v1.28.0 → v1.33.0
  • go.opentelemetry.io/otel/sdk: v1.28.0 → v1.33.0
  • go.opentelemetry.io/otel/trace: v1.28.0 → v1.33.0
  • go.opentelemetry.io/otel: v1.28.0 → v1.33.0
  • go.opentelemetry.io/proto/otlp: v1.3.1 → v1.4.0
  • golang.org/x/crypto: v0.28.0 → v0.36.0
  • golang.org/x/net: v0.30.0 → v0.38.0
  • golang.org/x/oauth2: v0.23.0 → v0.27.0
  • golang.org/x/sync: v0.8.0 → v0.12.0
  • golang.org/x/sys: v0.26.0 → v0.31.0
  • golang.org/x/term: v0.25.0 → v0.30.0
  • golang.org/x/text: v0.19.0 → v0.23.0
  • golang.org/x/time: v0.7.0 → v0.9.0
  • google.golang.org/genproto/googleapis/api: f6391c0e6fa225
  • google.golang.org/genproto/googleapis/rpc: f6391c0e6fa225
  • google.golang.org/grpc: v1.65.0 → v1.68.1
  • google.golang.org/protobuf: v1.35.1 → v1.36.5
  • k8s.io/api: v0.32.0 → v0.33.0
  • k8s.io/apiextensions-apiserver: v0.32.0 → v0.33.0
  • k8s.io/apimachinery: v0.32.0 → v0.33.0
  • k8s.io/apiserver: v0.32.0 → v0.33.0
  • k8s.io/client-go: v0.32.0 → v0.33.0
  • k8s.io/code-generator: v0.32.0 → v0.33.0
  • k8s.io/component-base: v0.32.0 → v0.33.0
  • k8s.io/gengo/v2: 2b362381244d31
  • k8s.io/kms: v0.32.0 → v0.33.0
  • k8s.io/kube-openapi: 32ad38ec8a335a
  • sigs.k8s.io/apiserver-network-proxy/konnectivity-client: v0.31.0 → v0.31.2
  • sigs.k8s.io/structured-merge-diff/v4: v4.4.2 → v4.6.0
Removed
  • github.com/asaskevich/govalidator: f61b66f
  • github.com/go-kit/log: v0.2.1
  • github.com/go-logfmt/logfmt: v0.5.1
  • google.golang.org/appengine: v1.6.7
  • gopkg.in/square/go-jose.v2: v2.6.0

Thanks to all our contributors! 😊


Configuration

📅 Schedule: Branch creation - "after 5am on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.

This PR has been generated by MintMaker (powered by Renovate Bot).

Copy link
Contributor Author

red-hat-konflux bot commented Mar 2, 2025

ℹ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 5 additional dependencies were updated
  • The go directive was updated for compatibility reasons

Details:

Package Change
go 1.23.0 -> 1.24.0
go (toolchain) 1.23.10 -> 1.24.4
k8s.io/api v0.32.3 -> v0.33.0
k8s.io/apimachinery v0.32.3 -> v0.33.0
k8s.io/client-go v0.32.3 -> v0.33.0
golang.org/x/time v0.8.0 -> v0.9.0
k8s.io/apiextensions-apiserver v0.32.2 -> v0.33.0

@openshift-ci openshift-ci bot requested review from bparees and xrajesh March 2, 2025 08:50
Copy link

openshift-ci bot commented Mar 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raptorsun for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/main/sigs.k8s.io-controller-runtime-0.x branch from 8adfb96 to d43712a Compare March 30, 2025 17:19
@red-hat-konflux red-hat-konflux bot changed the title fix(deps): update module sigs.k8s.io/controller-runtime to v0.20.2 fix(deps): update module sigs.k8s.io/controller-runtime to v0.20.4 Mar 30, 2025
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/main/sigs.k8s.io-controller-runtime-0.x branch from d43712a to 4b3c8c9 Compare April 6, 2025 14:10
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/main/sigs.k8s.io-controller-runtime-0.x branch from 4b3c8c9 to 76fc7b5 Compare April 13, 2025 14:19
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2025
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/main/sigs.k8s.io-controller-runtime-0.x branch from 76fc7b5 to 3302ebe Compare June 15, 2025 09:47
@red-hat-konflux red-hat-konflux bot changed the title fix(deps): update module sigs.k8s.io/controller-runtime to v0.20.4 fix(deps): update module sigs.k8s.io/controller-runtime to v0.21.0 Jun 15, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2025
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/main/sigs.k8s.io-controller-runtime-0.x branch from 3302ebe to e576cdf Compare June 22, 2025 11:57
Copy link
Contributor Author

Caution

There are some errors in your PipelineRun template.

PipelineRun Error
ols-e2e-tests-416 no kind "IntegrationTestScenario" is registered for version "appstudio.redhat.com/v1beta1" in scheme "k8s.io/client-go/kubernetes/scheme/register.go:83"

@raptorsun
Copy link
Contributor

/hold
require go 1.24

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2025
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/main/sigs.k8s.io-controller-runtime-0.x branch 2 times, most recently from c091c0e to 08aeb93 Compare July 6, 2025 06:24
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/main/sigs.k8s.io-controller-runtime-0.x branch from 08aeb93 to 115d373 Compare July 13, 2025 08:09
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/main/sigs.k8s.io-controller-runtime-0.x branch 2 times, most recently from 078f3d1 to e5cd365 Compare August 3, 2025 08:06
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/main/sigs.k8s.io-controller-runtime-0.x branch from e5cd365 to b8343ce Compare August 10, 2025 08:31
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/main/sigs.k8s.io-controller-runtime-0.x branch from b8343ce to 0d1b99c Compare August 17, 2025 12:14
Copy link

openshift-ci bot commented Aug 17, 2025

@red-hat-konflux[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bundle-e2e-4-17 4b3c8c9 link true /test bundle-e2e-4-17
ci/prow/lint 0d1b99c link true /test lint
ci/prow/ci-index-lightspeed-bundle-test 0d1b99c link true /test ci-index-lightspeed-bundle-test
ci/prow/bundle-e2e-4-18 0d1b99c link true /test bundle-e2e-4-18
ci/prow/unit 0d1b99c link true /test unit
ci/prow/generate 0d1b99c link true /test generate
ci/prow/images 0d1b99c link true /test images
ci/prow/fips-image-scan-operator 0d1b99c link true /test fips-image-scan-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@raptorsun
Copy link
Contributor

/close
replaced by #807

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 20, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Aug 20, 2025

@raptorsun: Closed this PR.

In response to this:

/close
replaced by #807

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot closed this Aug 20, 2025
Copy link
Contributor Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (v0.21.0). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@red-hat-konflux red-hat-konflux bot deleted the konflux/mintmaker/main/sigs.k8s.io-controller-runtime-0.x branch August 20, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants