Skip to content

Conversation

sriroopar
Copy link
Contributor

@sriroopar sriroopar commented Aug 13, 2025

Description

Functionality has been added in order to ensure that the reconciliation happens in the postgres pod by watching the config for deletion of ca certs. This will allow the e2e test to run successfully.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
    Functionality was verified by watching reconciliation activity when ca cert was intentionally deleted.

  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

The fix was verified by deleting the postgres-cert secret, and watching the recreation and roll out of the pod.

image

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 13, 2025

@sriroopar: This pull request references OLS-1775 which is a valid jira issue.

In response to this:

Description

Functionality has been added in order to ensure that the reconciliation happens in the postgres pod by watching the config for deletion of ca certs. This will allow the e2e test to run successfully.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
    Functionality was verified by watching reconciliation activity when ca cert was intentionally deleted.

  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

The fix was verified by deleting the postgres-cert secret, and watching the recreation and roll out of the pod.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 13, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2025
Copy link

openshift-ci bot commented Aug 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshuawilson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2025
@sriroopar sriroopar marked this pull request as draft August 13, 2025 12:56
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2025
@sriroopar
Copy link
Contributor Author

/test bundle-e2e-4-18

1 similar comment
@sriroopar
Copy link
Contributor Author

/test bundle-e2e-4-18

@sriroopar
Copy link
Contributor Author

/retest

1 similar comment
@sriroopar
Copy link
Contributor Author

/retest

@sriroopar sriroopar marked this pull request as ready for review September 2, 2025 11:54
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2025
@openshift-ci openshift-ci bot requested a review from xrajesh September 2, 2025 11:54
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 2, 2025

@sriroopar: This pull request references OLS-1775 which is a valid jira issue.

In response to this:

Description

Functionality has been added in order to ensure that the reconciliation happens in the postgres pod by watching the config for deletion of ca certs. This will allow the e2e test to run successfully.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
    Functionality was verified by watching reconciliation activity when ca cert was intentionally deleted.

  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

The fix was verified by deleting the postgres-cert secret, and watching the recreation and roll out of the pod.

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sriroopar
Copy link
Contributor Author

/test bundle-e2e-4-18

@sriroopar
Copy link
Contributor Author

/retest

@sriroopar
Copy link
Contributor Author

/test bundle-e2e-4-18

Copy link

openshift-ci bot commented Sep 3, 2025

@sriroopar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bundle-e2e-4-18 6e5fbdd link true /test bundle-e2e-4-18

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants