Skip to content

OLS-2025: Add config collection option #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

OLS-2025: Add config collection option #906

wants to merge 4 commits into from

Conversation

onmete
Copy link
Contributor

@onmete onmete commented Aug 14, 2025

Description

Add config collection option.
Service PR: openshift/lightspeed-service#2582

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 14, 2025 •
edited by openshift-ci bot
Loading

@onmete: This pull request references OLS-2025 which is a valid jira issue.

In response to this:

Description

Add config collection option.
Service PR: openshift/lightspeed-service#2582

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 14, 2025
@onmete onmete mentioned this pull request Aug 14, 2025
Open
14 tasks
@onmete onmete force-pushed the include-config-collection branch from 7aa18df to 1742207 Compare August 14, 2025 10:50
xrajesh
xrajesh reviewed Aug 14, 2025
View reviewed changes
api/v1alpha1/olsconfig_types.go Outdated
@@ -391,6 +391,8 @@ type UserDataCollectionSpec struct {
FeedbackDisabled bool `json:"feedbackDisabled,omitempty"`
// +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Do Not Collect Transcripts"
TranscriptsDisabled bool `json:"transcriptsDisabled,omitempty"`
// +operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Do Not Collect Config Data"
ConfigDisabled bool `json:"configDisabled,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want a new fields for this or we can make use of TranscriptsDisabled ? @onmete

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a separate data/option. Can you remind me if this is exposed to the user/admin, or if there is a single switch about collecting/not collecting data?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onmete I was thinking we will use the other 2 flags ( FeedbackDisabled and TranscriptsDisabled ) to decide if we want to collect Config - pre discussion with @thoraxe . But I am okay with this since we already added the flag .

@onmete onmete force-pushed the include-config-collection branch from ef9dd6a to 765fef3 Compare August 18, 2025 17:49
@onmete
Copy link
Contributor Author

onmete commented Aug 18, 2025

@xrajesh updated, can you check?

@raptorsun
Copy link
Contributor

the changes looks ok. we need regenerate the bundle, too, so that the new field is added to the CRD.
BUNDLE_TAG=1.0.3 make bundle

@onmete
Copy link
Contributor Author

onmete commented Aug 20, 2025

@raptorsun bunch of failures about trusted_task.trusted, should I retest?

@raptorsun
Copy link
Contributor

/hold
checking in progress

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2025
@xrajesh
Copy link
Contributor

xrajesh commented Aug 21, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2025
@raptorsun
Copy link
Contributor

/unhold
/lgtm
shall we merge for this release or wait for the next? @xrajesh

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2025
@raptorsun
Copy link
Contributor

we need to merge the service PR first. openshift/lightspeed-service#2582

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from raptorsun. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 21, 2025

@onmete: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@raptorsun
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@onmete
Copy link
Contributor Author

onmete commented Sep 3, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrajesh xrajesh xrajesh left review comments

@joshuawilson joshuawilson Awaiting requested review from joshuawilson

@raptorsun raptorsun Awaiting requested review from raptorsun

Assignees

@raptorsun raptorsun

@xrajesh xrajesh

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@onmete @openshift-ci-robot @raptorsun @xrajesh @openshift-merge-robot