OLS-1920: Ensuring quota limits get updated in the new app-server configmap.

[sriroopar]

Description

When quota-limits are updated/deleted on the go, updates were not reflecting on the restarted app-server's configmap, the old quota-limits were still being used. The changes made in the PR will ensure that the updated configmap is used by the restarting app-server.

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up dependent library

Related Tickets & Documents

• Related Issue #
• Closes [# OLS-1920 ](https://issues.redhat.com/browse/OLS-1920)

Checklist before requesting a review

• I have performed a self-review of my code.
• PR has passed all pre-merge test jobs.
• If it is a core feature, I have added thorough tests.

Testing

• Please provide detailed steps to perform tests related to this code change.

To test the fix, apply an olsconfig with quota-limits, delete a quota-limit and verify that the restarted app-server only has the quota-limit that wasn't deleted.

• How were the fix/results from this change verified? Please provide relevant screenshots or results.

• An OLSCONFIG was set up with 2 quota-limiters.
• One of those were deleted.
• OLSCONFIG of the restarting app server was verified manually, to verify the deletion.
• Only one of the limiters ( one that wasn't deleted) appeared on the configmap.

[openshift-ci-robot]

@sriroopar: This pull request references OLS-1920 which is a valid jira issue.

In response to this:

Description

When quota-limits are updated/deleted on the go, updates were not reflecting on the restarted app-server's configmap, the old quota-limits were still being used. The changes made in the PR will ensure that the updated configmap is used by the restarting app-server.

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up dependent library

Related Tickets & Documents

• Related Issue #
• Closes [# OLS-1920 ](https://issues.redhat.com/browse/OLS-1920)

Checklist before requesting a review

• I have performed a self-review of my code.
• PR has passed all pre-merge test jobs.
• If it is a core feature, I have added thorough tests.

Testing

• Please provide detailed steps to perform tests related to this code change.

To test the fix, apply an olsconfig with quota-limits, delete a quota-limit and verify that the restarted app-server only has the quota-limit that wasn't deleted.

• How were the fix/results from this change verified? Please provide relevant screenshots or results.

• An OLSCONFIG was set up with 2 quota-limiters.
• One of those were deleted.
• OLSCONFIG of the restarting app server was verified manually, to verify the deletion.
• Only one of the limiters ( one that wasn't deleted) appeared on the configmap.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xrajesh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@sriroopar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[xrajesh]

I dont see the problem is happening as the way it is described in OLS-1920 . I see the quota config is getting updated in olsconfig [working as I expect] - But not in the quota_limit table .
/hold