Skip to content

OCPBUGS-61180: Refactor config duplicate 416 #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: release-4.16
Choose a base branch
from
Open

OCPBUGS-61180: Refactor config duplicate 416 #485

wants to merge 2 commits into from

Conversation

josephdrichard
Copy link
Contributor

No description provided.

@josephdrichard
Allow duplicate keys in ptpconfig
df954b2 
When initially designing PTP config parsing, there was an assumption
that for each section, all of the keys were unique.  Based on this
assumption, key:value pairs for a given section were stored as a
map[string][string].

With the introduction of unicast_master_table, this assumption is no
longer true, as in the case of the UDPv4 key, there can be multiple
entries with the same key.  As such, the config data structure is
changed to maintain a list of individual key:value pairs, rather than a
map of keys to values.

In addition, some restructuring was done for places that relied on the
pre-existing structure, moving most of that functionality to utility
functions in config.go
@josephdrichard
masterOnly 0 under [global] section shouldn't affect clockType
4c99238
@openshift-ci openshift-ci bot requested review from s1061123 and SchSeba September 3, 2025 01:58
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephdrichard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2025
@josephdrichard
Copy link
Contributor Author

/jira cherrypick OCPBUGS-60193

@openshift-ci-robot
Copy link
Contributor

@josephdrichard: Jira Issue OCPBUGS-60193 has been cloned as Jira Issue OCPBUGS-61180. Will retitle bug to link to clone.
/retitle OCPBUGS-61180: Refactor config duplicate 416

In response to this:

/jira cherrypick OCPBUGS-60193

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title Refactor config duplicate 416 OCPBUGS-61180: Refactor config duplicate 416 Sep 3, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Sep 3, 2025
@openshift-ci-robot
Copy link
Contributor

@josephdrichard: This pull request references Jira Issue OCPBUGS-61180, which is invalid:

  • expected dependent Jira Issue OCPBUGS-60193 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 3, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 3, 2025

@josephdrichard: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1061123 s1061123 Awaiting requested review from s1061123

@SchSeba SchSeba Awaiting requested review from SchSeba

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephdrichard @openshift-ci-robot