Skip to content

Conversation

jakobmoellerdev
Copy link
Contributor

readjusts the mount directory to /var/lib to not induce conflicts with ostree state management. paths are still synchronized from /etc/topolvm via a watch from /etc to /var/lib in microshift

See openshift/microshift#3535 (comment) for the reasoning background and openshift/microshift@a66137a for adjustment on the implementation on microshift

readjusts the mount directory to /var/lib to not induce conflicts with ostree state management. paths are still synchronized from /etc/topolvm via a watch from /etc to /var/lib in microshift

Signed-off-by: Jakob Möller <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 1, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 1, 2024

@jakobmoellerdev: This pull request references OCPEDGE-1126 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

readjusts the mount directory to /var/lib to not induce conflicts with ostree state management. paths are still synchronized from /etc/topolvm via a watch from /etc to /var/lib in microshift

See openshift/microshift#3535 (comment) for the reasoning background and openshift/microshift@a66137a for adjustment on the implementation on microshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 1, 2024
@openshift-ci openshift-ci bot requested review from eggfoobar and qJkee July 1, 2024 15:04
Copy link
Contributor

openshift-ci bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.88%. Comparing base (bf9fc3a) to head (0e150d3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
- Coverage   57.95%   57.88%   -0.08%     
==========================================
  Files          53       53              
  Lines        4212     4212              
==========================================
- Hits         2441     2438       -3     
- Misses       1529     1531       +2     
- Partials      242      243       +1     
Files Coverage Δ
internal/controllers/vgmanager/lvmd/lvmd.go 55.31% <ø> (ø)

... and 3 files with indirect coverage changes

Copy link
Contributor

openshift-ci bot commented Jul 1, 2024

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@suleymanakbas91
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 02ddcc0 into openshift:main Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants