Skip to content

[release-4.12] OCPBUGS-8411: Use lower case node names only #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[release-4.12] OCPBUGS-8411: Use lower case node names only #1469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ func NewMicroshiftConfig() *MicroshiftConfig {
return &MicroshiftConfig{
LogVLevel: 2,
SubjectAltNames: subjectAltNames,
NodeName: nodeName,
NodeName: strings.ToLower(nodeName),
NodeIP: nodeIP,
BaseDomain: "example.com",
Cluster: ClusterConfig{
Expand All @@ -233,7 +233,7 @@ func (c *MicroshiftConfig) isDefaultNodeName() bool {
if err != nil {
klog.Fatalf("Failed to get hostname %v", err)
}
return c.NodeName == hostname
return c.NodeName == strings.ToLower(hostname)
}

// Read or set the NodeName that will be used for this MicroShift instance
Expand Down Expand Up @@ -357,7 +357,7 @@ func (c *MicroshiftConfig) ReadFromConfigFile(configFile string) error {
// Wire new Config type to existing MicroshiftConfig
c.LogVLevel = config.GetVerbosity()
if config.Node.HostnameOverride != "" {
c.NodeName = config.Node.HostnameOverride
c.NodeName = strings.ToLower(config.Node.HostnameOverride)
}
if config.Node.NodeIP != "" {
c.NodeIP = config.Node.NodeIP
Expand Down