Skip to content

USHIFT-976: Override journald configuration rather than editing the system files #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2023
Merged

USHIFT-976: Override journald configuration rather than editing the system files #1518

merged 1 commit into from
Mar 17, 2023

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Mar 17, 2023 •
edited by openshift-ci bot
Loading

Closes USHIFT-976

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 17, 2023 •
edited by openshift-ci bot
Loading

@ggiguash: This pull request references USHIFT-976 which is a valid jira issue.

In response to this:

Closes USHIFT-976

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 17, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 17, 2023 •
edited by openshift-ci bot
Loading

@ggiguash: This pull request references USHIFT-976 which is a valid jira issue.

In response to this:

Closes USHIFT-976

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from pacevedom and pmtk March 17, 2023 06:52
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2023
@ggiguash ggiguash force-pushed the fix_journald_config branch from 0bd8a10 to dc5edfc Compare March 17, 2023 06:53
@dhellmann
Copy link
Contributor

/retest-required

@ggiguash
Copy link
Contributor Author

/retest

dhellmann
dhellmann reviewed Mar 17, 2023
View reviewed changes
Copy link
Contributor

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2023

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d409174 into openshift:main Mar 17, 2023
@ggiguash
Copy link
Contributor Author

/cherrypick release-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 18, 2023
Merged
@openshift-cherrypick-robot
Copy link

@ggiguash: new pull request created: #1524

In response to this:

/cherrypick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash ggiguash deleted the fix_journald_config branch March 20, 2023 11:53
@microshift-rebase-script microshift-rebase-script bot mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann dhellmann left review comments

@pacevedom pacevedom Awaiting requested review from pacevedom

@pmtk pmtk Awaiting requested review from pmtk

Assignees

@dhellmann dhellmann

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ggiguash @openshift-ci-robot @dhellmann @openshift-cherrypick-robot @openshift-merge-robot