Skip to content

USHIFT-2807: Add selected rpm-ostree scenario tests to bootc on CentOS #3225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 12, 2024
Merged

USHIFT-2807: Add selected rpm-ostree scenario tests to bootc on CentOS #3225

merged 3 commits into from
Apr 12, 2024

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Apr 8, 2024

No description provided.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 8, 2024 •
edited by openshift-ci bot
Loading

@ggiguash: This pull request references USHIFT-2807 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 8, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024
@ggiguash
Copy link
Contributor Author

ggiguash commented Apr 8, 2024

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

@ggiguash: The following commands are available to trigger required jobs:

  • /test images
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-metal-periodic-test
  • pull-ci-openshift-microshift-main-metal-periodic-test-arm
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash
Copy link
Contributor Author

ggiguash commented Apr 9, 2024

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 9, 2024

@ggiguash: The following commands are available to trigger required jobs:

  • /test images
  • /test metal-bootc-test
  • /test metal-bootc-test-arm
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-metal-bootc-test
  • pull-ci-openshift-microshift-main-metal-bootc-test-arm
  • pull-ci-openshift-microshift-main-metal-periodic-test
  • pull-ci-openshift-microshift-main-metal-periodic-test-arm
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash
Copy link
Contributor Author

ggiguash commented Apr 9, 2024

/test metal-bootc-test
/test metal-bootc-test-arm

@ggiguash
Copy link
Contributor Author

ggiguash commented Apr 9, 2024

/test metal-bootc-test

@ggiguash
Copy link
Contributor Author

ggiguash commented Apr 9, 2024

/test metal-bootc-test

1 similar comment
@ggiguash
Copy link
Contributor Author

/test metal-bootc-test

@ggiguash
Copy link
Contributor Author

/test metal-bootc-test

3 similar comments
@ggiguash
Copy link
Contributor Author

/test metal-bootc-test

@ggiguash
Copy link
Contributor Author

/test metal-bootc-test

@ggiguash
Copy link
Contributor Author

/test metal-bootc-test

@ggiguash ggiguash marked this pull request as ready for review April 11, 2024 14:31
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2024
@openshift-ci openshift-ci bot requested review from dhellmann and jerpeter1 April 11, 2024 14:33
pmtk
pmtk reviewed Apr 11, 2024
View reviewed changes
test/bin/pyutils/build_bootc_images.py
# Process a layer with group directories
for item in os.listdir(args.layer_dir):
# Process layer directory contents sorted by length and then alphabetically
for item in sorted(os.listdir(args.layer_dir), key=lambda i: (len(i), i)):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't help with parallelization of the process, right? Similar to what we have now, seems like cos9-bootc-source-optionals.containerfile is material for group2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very true. We have a separate issue on the parallelization USHIFT-2929. I think this is where we should do the restructuring and test the time gain, etc.

@ggiguash
Copy link
Contributor Author

The failed metal jobs do not seem to be related to the current change.
It should be ready for a review.

@pmtk
Copy link
Member

pmtk commented Apr 12, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Contributor Author

/override ci/prow/metal-periodic-test
/override ci/prow/metal-periodic-test-arm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/metal-periodic-test, ci/prow/metal-periodic-test-arm

In response to this:

/override ci/prow/metal-periodic-test
/override ci/prow/metal-periodic-test-arm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e12b2cc into openshift:main Apr 12, 2024
@ggiguash ggiguash deleted the src_to_bootc branch April 16, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann Awaiting requested review from dhellmann

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

1 more reviewer

@pmtk pmtk pmtk left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@pmtk pmtk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggiguash @openshift-ci-robot @pmtk