Skip to content

Conversation

pacevedom
Copy link
Contributor

Sometimes the operations are not deterministic or take too long. Remove whatever is not mandatory for the test, as listening in the new ports also means not listening in the old ones, so the test may be simplified and the flakes should disappear.

Which issue(s) this PR addresses:

Closes #

Sometimes the operations are not deterministic or take too long. Remove
whatever is not mandatory for the test, as listening in the new ports
also means not listening in the old ones, so the test may be simplified
and the flakes should disappear.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 15, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 15, 2024

@pacevedom: This pull request references USHIFT-2968 which is a valid jira issue.

In response to this:

Sometimes the operations are not deterministic or take too long. Remove whatever is not mandatory for the test, as listening in the new ports also means not listening in the old ones, so the test may be simplified and the flakes should disappear.

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from copejon and jerpeter1 April 15, 2024 12:56
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2024
@pacevedom
Copy link
Contributor Author

/test ?

Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

@pacevedom: The following commands are available to trigger required jobs:

  • /test images
  • /test metal-bootc-test
  • /test metal-bootc-test-arm
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacevedom
Copy link
Contributor Author

/test metal-periodic-test
/test metal-periodic-test-arm

@pacevedom
Copy link
Contributor Author

/override ci/prow/metal-periodic-test
Problem unrelated to this fix and also being addressed in a different PR.

@pacevedom
Copy link
Contributor Author

/override ci/prow/metal-periodic-test
/override ci/prow/metal-periodic-test-arm
These failures are addressed in #3235, not by this PR.

Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

@pacevedom: Overrode contexts on behalf of pacevedom: ci/prow/metal-periodic-test

In response to this:

/override ci/prow/metal-periodic-test
Problem unrelated to this fix and also being addressed in a different PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

@pacevedom: Overrode contexts on behalf of pacevedom: ci/prow/metal-periodic-test, ci/prow/metal-periodic-test-arm

In response to this:

/override ci/prow/metal-periodic-test
/override ci/prow/metal-periodic-test-arm
These failures are addressed in #3235, not by this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eslutsky
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2024
Copy link
Contributor

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eslutsky, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacevedom
Copy link
Contributor Author

/test microshift-metal-tests-arm

Copy link
Contributor

openshift-ci bot commented Apr 16, 2024

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 594ba2d into openshift:main Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants