-
Notifications
You must be signed in to change notification settings - Fork 216
USHIFT-2968: Simplify router tests #3238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sometimes the operations are not deterministic or take too long. Remove whatever is not mandatory for the test, as listening in the new ports also means not listening in the old ones, so the test may be simplified and the flakes should disappear.
@pacevedom: This pull request references USHIFT-2968 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test ? |
@pacevedom: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test metal-periodic-test |
/override ci/prow/metal-periodic-test |
/override ci/prow/metal-periodic-test |
@pacevedom: Overrode contexts on behalf of pacevedom: ci/prow/metal-periodic-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pacevedom: Overrode contexts on behalf of pacevedom: ci/prow/metal-periodic-test, ci/prow/metal-periodic-test-arm In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eslutsky, pacevedom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test microshift-metal-tests-arm |
@pacevedom: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sometimes the operations are not deterministic or take too long. Remove whatever is not mandatory for the test, as listening in the new ports also means not listening in the old ones, so the test may be simplified and the flakes should disappear.
Which issue(s) this PR addresses:
Closes #