Skip to content

USHIFT-2992: Changes to scripts for RHEL9.4 #3251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 22, 2024
Merged

USHIFT-2992: Changes to scripts for RHEL9.4 #3251

merged 5 commits into from
Apr 22, 2024

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Apr 18, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2024 •
edited by openshift-ci bot
Loading

@pmtk: This pull request references USHIFT-2992 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ggiguash and pliurh April 18, 2024 10:08
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
@pmtk
Copy link
Member Author

pmtk commented Apr 18, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
@pmtk pmtk force-pushed the rhel94/enable-rhocp-for-beta branch 2 times, most recently from 56ae835 to 73ac186 Compare April 18, 2024 12:31
@pmtk pmtk marked this pull request as draft April 18, 2024 13:48
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2024
@pmtk pmtk force-pushed the rhel94/enable-rhocp-for-beta branch from d1c6752 to ab41564 Compare April 18, 2024 14:42
@pmtk pmtk force-pushed the rhel94/enable-rhocp-for-beta branch from 59ce5d1 to 7002184 Compare April 19, 2024 11:02
@pmtk pmtk changed the title USHIFT-2992: Enable RHOCP for beta RHEL USHIFT-2992: Changes to scripts for RHEL9.4 Apr 19, 2024
@pmtk pmtk marked this pull request as ready for review April 19, 2024 11:03
@pmtk
Copy link
Member Author

pmtk commented Apr 19, 2024

/unhold

@openshift-ci openshift-ci bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 19, 2024
@openshift-ci openshift-ci bot requested a review from dhellmann April 19, 2024 11:05
@pmtk pmtk mentioned this pull request Apr 19, 2024
Merged
@pmtk
Copy link
Member Author

pmtk commented Apr 19, 2024

/retest

ggiguash
ggiguash reviewed Apr 19, 2024
View reviewed changes
scripts/image-builder/cleanup.sh Outdated
@@ -82,6 +82,7 @@ restart_osbuilder_services() {
if ! systemctl is-active -q osbuild-composer.socket &>/dev/null ; then
title "Starting osbuild services"
sudo systemctl start osbuild-composer.socket
sleep 1 # Give composer some time to be ready for workers
Copy link
Contributor

@ggiguash ggiguash Apr 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to have sleep as it is not reliable.
Can we try starting workers 3 times in a loop with sleep in between?

@pmtk pmtk force-pushed the rhel94/enable-rhocp-for-beta branch from 7002184 to c636c8b Compare April 22, 2024 07:29
@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5d74d43 and 2 for PR HEAD c636c8b in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit fbe02a5 into openshift:main Apr 22, 2024
@pmtk pmtk deleted the rhel94/enable-rhocp-for-beta branch April 22, 2024 13:25
@ggiguash ggiguash mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pliurh pliurh Awaiting requested review from pliurh

@dhellmann dhellmann Awaiting requested review from dhellmann

1 more reviewer

@ggiguash ggiguash ggiguash left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@ggiguash ggiguash

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmtk @openshift-ci-robot @ggiguash