Skip to content

[release-4.15] USHIFT-3276: Fix remove_vm function to keep info files when not fully deleted #3499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2024
Merged

[release-4.15] USHIFT-3276: Fix remove_vm function to keep info files when not fully deleted #3499

merged 1 commit into from
Jun 17, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #3492

/assign ggiguash

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 17, 2024
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 17, 2024 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: USHIFT-3136

In response to this:

This is an automated cherry-pick of #3492

/assign ggiguash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from copejon and dhellmann June 17, 2024 08:50
@ggiguash
Copy link
Contributor

ggiguash commented Jun 17, 2024 •
edited by openshift-ci bot
Loading

/retitle [release-4.15] USHIFT-3276: Fix remove_vm function to keep info files when not fully deleted

@openshift-ci openshift-ci bot changed the title [release-4.15] USHIFT-3136: Fix remove_vm function to keep info files when not fully deleted [release-4.15] USHIFT-3276: Fix remove_vm function to keep info files when not fully deleted Jun 17, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 17, 2024 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: This pull request references USHIFT-3276 which is a valid jira issue.

In response to this:

This is an automated cherry-pick of #3492

/assign ggiguash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor

/label backport-risk-assessed
/label jira/valid-bug
/lgtm
/label cherry-pick-approved

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. labels Jun 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 17, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6930b3f into openshift:release-4.15 Jun 17, 2024
@microshift-rebase-script microshift-rebase-script bot mentioned this pull request Feb 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copejon copejon Awaiting requested review from copejon

@dhellmann dhellmann Awaiting requested review from dhellmann

Assignees

@ggiguash ggiguash

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @openshift-ci-robot @ggiguash