-
Notifications
You must be signed in to change notification settings - Fork 216
NO-ISSUE: Add runtime crun to crio for y-2 blueprint #3527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: Add runtime crun to crio for y-2 blueprint #3527
Conversation
@pmtk: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/override ci/prow/microshift-metal-tests ci/prow/microshift-metal-tests-arm Because test we're trying to fix here is using images from cache, it's not taking into consideration change in this PR. We need to merge this, so next night it's rebuilt. |
@pmtk: Overrode contexts on behalf of pmtk: ci/prow/microshift-metal-tests, ci/prow/microshift-metal-tests-arm In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@pmtk: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Will open a ticket to remember this.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pacevedom, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
microshift 4.15 RPM still specifies
crio >= 1.25
and doesn't ship its owncrun
runtime definition for crio. When it gets newest crio (>= 1.29), the test fails because crio exits shortly after startup.This PR introduces a workaround: explicitly adds missing file to the blueprint.
When 4.15 RPM has its crio version fixed, we can remove the workaround.