Skip to content

Conversation

iranzo
Copy link
Member

@iranzo iranzo commented Oct 22, 2021

Adds CNAME to define domain to use by GHPages

@openshift-ci openshift-ci bot requested review from fzdarsky and mangelajo October 22, 2021 12:47
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 22, 2021

Hi @iranzo. Thanks for your PR.

I'm waiting for a redhat-et member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 22, 2021
@rootfs
Copy link
Member

rootfs commented Oct 22, 2021

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rootfs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 22, 2021
@rootfs rootfs merged commit 37061aa into openshift:main Oct 22, 2021
@iranzo iranzo deleted the addCNAME branch October 22, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants