Skip to content

USHIFT-4378: introduce ingress customization fields #4000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2024
Merged

USHIFT-4378: introduce ingress customization fields #4000

merged 1 commit into from
Nov 18, 2024

Conversation

eslutsky
Copy link
Contributor

Which issue(s) this PR addresses:

Closes #

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 30, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 30, 2024 •
edited by openshift-ci bot
Loading

@eslutsky: This pull request references USHIFT-4378 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 30, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 30, 2024
@eslutsky eslutsky force-pushed the ingress-performance branch 3 times, most recently from 596e573 to f6514a9 Compare October 1, 2024 13:28
pacevedom
pacevedom reviewed Oct 2, 2024
View reviewed changes
@eslutsky eslutsky force-pushed the ingress-performance branch from f6514a9 to 5b951a2 Compare October 2, 2024 09:58
@eslutsky
Copy link
Contributor Author

eslutsky commented Oct 3, 2024

/test all

@eslutsky eslutsky force-pushed the ingress-performance branch from 5b951a2 to edef4e4 Compare October 15, 2024 15:16
pacevedom
pacevedom reviewed Oct 15, 2024
View reviewed changes
@eslutsky eslutsky force-pushed the ingress-performance branch 13 times, most recently from dd07b07 to 916ae46 Compare October 24, 2024 09:18
@eslutsky eslutsky marked this pull request as ready for review October 24, 2024 09:19
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2024
@openshift-ci openshift-ci bot requested review from jogeo and pmtk October 24, 2024 09:19
@eslutsky eslutsky force-pushed the ingress-performance branch from 6af7c8b to 5b667f7 Compare November 11, 2024 11:07
@eslutsky
Copy link
Contributor Author

ROUTER_HTTP_IGNORE_PROBES
thanks @ShudiLi
it appears that haproxy.config expects "true" in ROUTER_HTTP_IGNORE_PROBES and ROUTER_DONT_LOG_NULL ENV, fixed.

@eslutsky eslutsky force-pushed the ingress-performance branch 4 times, most recently from 336f9be to d062aaf Compare November 12, 2024 09:40
@eslutsky
Copy link
Contributor Author

/test ocp-full-conformance-serial-optional-components-rhel-eus-arm

pacevedom
pacevedom reviewed Nov 12, 2024
View reviewed changes
@eslutsky eslutsky force-pushed the ingress-performance branch from d062aaf to 7363117 Compare November 13, 2024 09:32
@pmtk
Copy link
Member

pmtk commented Nov 13, 2024

this looks good to me

pacevedom
pacevedom reviewed Nov 13, 2024
View reviewed changes
@eslutsky eslutsky force-pushed the ingress-performance branch from 7363117 to 838a0c0 Compare November 14, 2024 12:01
@eslutsky
Copy link
Contributor Author

/retest

@eslutsky
Copy link
Contributor Author

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 15, 2024

@eslutsky: The following commands are available to trigger required jobs:

  • /test e2e-aws-footprint-and-performance
  • /test e2e-aws-tests
  • /test e2e-aws-tests-arm
  • /test e2e-aws-tests-bootc
  • /test e2e-aws-tests-bootc-arm
  • /test e2e-aws-tests-bootc-periodic
  • /test e2e-aws-tests-bootc-periodic-arm
  • /test e2e-aws-tests-cache
  • /test e2e-aws-tests-cache-arm
  • /test e2e-aws-tests-periodic
  • /test e2e-aws-tests-periodic-arm
  • /test images
  • /test ocp-full-conformance-optional-components-rhel-eus
  • /test ocp-full-conformance-optional-components-rhel-eus-arm
  • /test ocp-full-conformance-rhel-eus
  • /test ocp-full-conformance-rhel-eus-arm
  • /test ocp-full-conformance-serial-optional-components-rhel-eus
  • /test ocp-full-conformance-serial-optional-components-rhel-eus-arm
  • /test ocp-full-conformance-serial-rhel-eus
  • /test ocp-full-conformance-serial-rhel-eus-arm
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test security
  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-e2e-aws-tests
  • pull-ci-openshift-microshift-main-e2e-aws-tests-arm
  • pull-ci-openshift-microshift-main-e2e-aws-tests-bootc
  • pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm
  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-ocp-full-conformance-optional-components-rhel-eus
  • pull-ci-openshift-microshift-main-ocp-full-conformance-optional-components-rhel-eus-arm
  • pull-ci-openshift-microshift-main-ocp-full-conformance-rhel-eus
  • pull-ci-openshift-microshift-main-ocp-full-conformance-rhel-eus-arm
  • pull-ci-openshift-microshift-main-ocp-full-conformance-serial-optional-components-rhel-eus
  • pull-ci-openshift-microshift-main-ocp-full-conformance-serial-optional-components-rhel-eus-arm
  • pull-ci-openshift-microshift-main-ocp-full-conformance-serial-rhel-eus
  • pull-ci-openshift-microshift-main-ocp-full-conformance-serial-rhel-eus-arm
  • pull-ci-openshift-microshift-main-security
  • pull-ci-openshift-microshift-main-test-rebase
  • pull-ci-openshift-microshift-main-test-rpm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@eslutsky
Copy link
Contributor Author

/test e2e-aws-tests-cache

@eslutsky
Copy link
Contributor Author

/retest

@eslutsky
Copy link
Contributor Author

/test e2e-aws-tests-arm

pacevedom
pacevedom reviewed Nov 18, 2024
View reviewed changes
assets/components/openshift-router/deployment.yaml
@@ -40,7 +40,7 @@ spec:
- name: ROUTER_CIPHERSUITES
value: TLS_AES_128_GCM_SHA256:TLS_AES_256_GCM_SHA384:TLS_CHACHA20_POLY1305_SHA256
- name: ROUTER_DISABLE_HTTP2
value: "true"
value: '{{.RouterDisableHttp2}}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still missing? Its the only one I cant see in rebase.sh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap, it was hardcoded in rebase.sh - fixed

@eslutsky eslutsky force-pushed the ingress-performance branch from 838a0c0 to d66c874 Compare November 18, 2024 14:58
@eslutsky
Copy link
Contributor Author

squashed the extra commits

@eslutsky
Copy link
Contributor Author

/test test-rebase

pacevedom
pacevedom approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eslutsky, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eslutsky
Copy link
Contributor Author

/test e2e-aws-tests-bootc-arm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

@eslutsky: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security d66c874 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8921062 into openshift:main Nov 18, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogeo jogeo Awaiting requested review from jogeo

2 more reviewers

@pmtk pmtk pmtk left review comments

@pacevedom pacevedom pacevedom approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@pacevedom pacevedom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eslutsky @openshift-ci-robot @pmtk @jerpeter1 @ShudiLi @pacevedom