Skip to content

USHIFT-4343: Add test scenario for flannel CNI plugin #4034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 9, 2024
Merged

USHIFT-4343: Add test scenario for flannel CNI plugin #4034

merged 3 commits into from
Oct 9, 2024

Conversation

praveenkumar
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 7, 2024 •
edited by openshift-ci bot
Loading

@praveenkumar: This pull request references USHIFT-4343 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@praveenkumar praveenkumar marked this pull request as ready for review October 7, 2024 15:51
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2024
@openshift-ci openshift-ci bot requested review from jogeo and pliurh October 7, 2024 15:52
ggiguash
ggiguash reviewed Oct 8, 2024
View reviewed changes
ggiguash
ggiguash reviewed Oct 8, 2024
View reviewed changes
@praveenkumar
test/bin/ci_phase_iso_build.sh: Add WITH_FLANNEL env
ab3dfc9 
This PR adds `WITH_FLANNEL` env before execution of
`build_bootc_images.sh` so that it will now build
`microshift-flannel` packages also to consume it in
next commit for adding network smoke test for flannel.
@praveenkumar
Copy link
Contributor Author

/test e2e-aws-tests-bootc

ggiguash
ggiguash reviewed Oct 9, 2024
View reviewed changes
ggiguash
ggiguash reviewed Oct 9, 2024
View reviewed changes
ggiguash
ggiguash reviewed Oct 9, 2024
View reviewed changes
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

@praveenkumar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ggiguash
Copy link
Contributor

ggiguash commented Oct 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, praveenkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 814c550 into openshift:main Oct 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogeo jogeo Awaiting requested review from jogeo

@pliurh pliurh Awaiting requested review from pliurh

1 more reviewer

@ggiguash ggiguash ggiguash left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@ggiguash ggiguash

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@praveenkumar @openshift-ci-robot @ggiguash