Skip to content

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Oct 8, 2024

Fixes the following error:

$ ./test/bin/build_bootc_images.sh -l ./test/image-blueprints/layer5-bootc/ 
06:26:22.565109968 An error occurred: run_command() missing 1 required positional argument: 'dry_run'
Traceback (most recent call last):
  File "/home/microshift/microshift/test/bin/pyutils/build_bootc_images.py", line 548, in main
    common.run_command(f"{SCRIPTDIR}/build_rpms.sh")
TypeError: run_command() missing 1 required positional argument: 'dry_run'
06:26:22.565556287 Running atexit cleanup
06:26:22.567635774 [SHELL] sudo podman ps --filter ancestor=[registry.redhat.io/rhel9/bootc-image-builder:latest](http://registry.redhat.io/rhel9/bootc-image-builder:latest) --format {{.ID}}
06:26:22.597914457 Build FAILED

@ggiguash ggiguash changed the title Fix build_rpm.sh call when building bootc images NO-ISSUE: Fix build_rpm.sh call when building bootc images Oct 8, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 8, 2024
@openshift-ci-robot
Copy link

@ggiguash: This pull request explicitly references no jira issue.

In response to this:

Fixes the following error:

$ ./test/bin/build_bootc_images.sh -l ./test/image-blueprints/layer5-bootc/ 
06:26:22.565109968 An error occurred: run_command() missing 1 required positional argument: 'dry_run'
Traceback (most recent call last):
  File "/home/microshift/microshift/test/bin/pyutils/build_bootc_images.py", line 548, in main
    common.run_command(f"{SCRIPTDIR}/build_rpms.sh")
TypeError: run_command() missing 1 required positional argument: 'dry_run'
06:26:22.565556287 Running atexit cleanup
06:26:22.567635774 [SHELL] sudo podman ps --filter ancestor=[registry.redhat.io/rhel9/bootc-image-builder:latest](http://registry.redhat.io/rhel9/bootc-image-builder:latest) --format {{.ID}}
06:26:22.597914457 Build FAILED

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from copejon and pliurh October 8, 2024 07:16
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2024
@pmtk
Copy link
Member

pmtk commented Oct 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2024
Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f6912bf into openshift:main Oct 8, 2024
12 checks passed
@ggiguash ggiguash deleted the fix_build_rpms_call branch October 10, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants