-
Notifications
You must be signed in to change notification settings - Fork 216
update docs Makefile #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docs Makefile #404
Conversation
✔️ Deploy Preview for microshift ready! 🔨 Explore the source changes: 4082142 🔍 Inspect the deploy log: https://app.netlify.com/sites/microshift/deploys/617dd932979608000823dcdb 😎 Browse the preview: https://deploy-preview-404--microshift.netlify.app |
@sallyom should we specify to potentially disable selinux or provide a context when launching? Everything is good to go otherwise |
Signed-off-by: Sally O'Malley <[email protected]>
085c74c
to
4082142
Compare
@sallyom: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Let's hold this until we discuss next week, there's question whether the docs targets work on various systems (fedora, mac, other) - also, should we move the docs targets to the root Makefile (i pushed that change here)? Or, should we keep a separate docs/Makefile? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thank you!! :)
It should probably work on various systems as we ar using docker/podman. |
/LGTM |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cooktheryan, mangelajo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Sally O'Malley [email protected]
This works for me, I'm running on fedora. Anyone else?
The serve output suggests viewing at
0.0.0.0:4000
however I view at127.0.0.1:4000