Skip to content

Conversation

sallyom
Copy link
Contributor

@sallyom sallyom commented Oct 29, 2021

Signed-off-by: Sally O'Malley [email protected]

This works for me, I'm running on fedora. Anyone else?

The serve output suggests viewing at 0.0.0.0:4000 however I view at 127.0.0.1:4000

@openshift-ci openshift-ci bot requested review from copejon and fzdarsky October 29, 2021 15:00
@netlify
Copy link

netlify bot commented Oct 29, 2021

✔️ Deploy Preview for microshift ready!

🔨 Explore the source changes: 4082142

🔍 Inspect the deploy log: https://app.netlify.com/sites/microshift/deploys/617dd932979608000823dcdb

😎 Browse the preview: https://deploy-preview-404--microshift.netlify.app

@cooktheryan
Copy link
Contributor

@sallyom should we specify to potentially disable selinux or provide a context when launching?

Everything is good to go otherwise

Signed-off-by: Sally O'Malley <[email protected]>
@sallyom sallyom force-pushed the update-docs-makefile branch from 085c74c to 4082142 Compare October 30, 2021 23:45
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2021

@sallyom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-sig-auth 4082142 link false /test e2e-openshift-conformance-sig-auth
ci/prow/e2e-openshift-conformance-sig-cli 4082142 link false /test e2e-openshift-conformance-sig-cli

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sallyom
Copy link
Contributor Author

sallyom commented Oct 31, 2021

@sallyom should we specify to potentially disable selinux or provide a context when launching?

Everything is good to go otherwise

Let's hold this until we discuss next week, there's question whether the docs targets work on various systems (fedora, mac, other) - also, should we move the docs targets to the root Makefile (i pushed that change here)? Or, should we keep a separate docs/Makefile?

Copy link
Contributor

@mangelajo mangelajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you!! :)

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 2, 2021
@mangelajo
Copy link
Contributor

@sallyom should we specify to potentially disable selinux or provide a context when launching?
Everything is good to go otherwise

Let's hold this until we discuss next week, there's question whether the docs targets work on various systems (fedora, mac, other) - also, should we move the docs targets to the root Makefile (i pushed that change here)? Or, should we keep a separate docs/Makefile?

It should probably work on various systems as we ar using docker/podman.

@cooktheryan
Copy link
Contributor

/LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cooktheryan, mangelajo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants