Skip to content

Conversation

cooktheryan
Copy link
Contributor

Carry-on from @tosin2013 #179

Adding clean up script for issue 168
#168

@openshift-ci openshift-ci bot requested review from mangelajo and sallyom October 31, 2021 20:09
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 31, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign husky-parul after the PR has been reviewed.
You can assign the PR to them by writing /assign @husky-parul in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Oct 31, 2021

✔️ Deploy Preview for microshift canceled.

🔨 Explore the source changes: a4a1b1f

🔍 Inspect the deploy log: https://app.netlify.com/sites/microshift/deploys/617ef80f8a8eb5000828ec9b

@cooktheryan cooktheryan requested review from copejon and removed request for mangelajo and sallyom November 1, 2021 12:56
@cooktheryan cooktheryan changed the title Tosin2013 main Uninstall script Nov 1, 2021
@mangelajo
Copy link
Contributor

Looks good, github says it needs a rebase.

Let's squash it at merge (or during the rebase process) thanks Ryan!

@cooktheryan
Copy link
Contributor Author

@copejon can I get a review on this one

@mangelajo
Copy link
Contributor

/assign copejon

@cooktheryan
Copy link
Contributor Author

closing as we are going to move to RPMs and containers soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants