Skip to content

Conversation

cooktheryan
Copy link
Contributor

Closes #340

@netlify
Copy link

netlify bot commented Nov 1, 2021

✔️ Deploy Preview for microshift ready!

🔨 Explore the source changes: f7d8150

🔍 Inspect the deploy log: https://app.netlify.com/sites/microshift/deploys/61813a97a125560007626358

😎 Browse the preview: https://deploy-preview-406--microshift.netlify.app

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 1, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mangelajo after the PR has been reviewed.
You can assign the PR to them by writing /assign @mangelajo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from rootfs and sallyom November 1, 2021 18:46
@cooktheryan cooktheryan requested review from mangelajo and oglok and removed request for rootfs and sallyom November 1, 2021 18:46
@cooktheryan
Copy link
Contributor Author

@iranzo is there anything I should do to ensure that this file will get picked up for the webpage?

@iranzo
Copy link
Member

iranzo commented Nov 2, 2021

@iranzo is there anything I should do to ensure that this file will get picked up for the webpage?

1- Put some content ;-)
2- Put yaml preamble
3- probably... link it on the main menu if it's a 'page' in the same way as others are linked in the _config.yaml

Copy link
Contributor

@mangelajo mangelajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, something happened the commit looks empty

@cooktheryan
Copy link
Contributor Author

well that is weird...

@iranzo
Copy link
Member

iranzo commented Nov 2, 2021

Soooo, next step is probably adding yaml preamble, I would merge as it is now, so that the content is there, and move to different repo all the website stuff to make it easier to add content and preview witout getting everyone else nervous with the pr's :)

@cooktheryan cooktheryan requested a review from mangelajo November 2, 2021 14:00
@cooktheryan
Copy link
Contributor Author

moving to docs repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Look at how to provide VIPs in local network
3 participants