Skip to content

Conversation

sallyom
Copy link
Contributor

@sallyom sallyom commented Nov 2, 2021

Signed-off-by: Sally O'Malley [email protected]

quick fix

@openshift-ci openshift-ci bot requested review from fzdarsky and mangelajo November 2, 2021 15:19
@netlify
Copy link

netlify bot commented Nov 2, 2021

✔️ Deploy Preview for microshift canceled.

🔨 Explore the source changes: 4234597

🔍 Inspect the deploy log: https://app.netlify.com/sites/microshift/deploys/61815df77609720009ff63f2

@sallyom
Copy link
Contributor Author

sallyom commented Nov 2, 2021

@cooktheryan please merge, thanks!

I still see a permissions issue when building docs without sudo, working on that now, but this should be fixed first

@cooktheryan
Copy link
Contributor

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2021
Signed-off-by: Sally O'Malley <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 2, 2021

@sallyom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-sig-auth 4234597 link false /test e2e-openshift-conformance-sig-auth
ci/prow/e2e-openshift-conformance-sig-storage 4234597 link false /test e2e-openshift-conformance-sig-storage
ci/prow/e2e-openshift-conformance-sig-api-machinery 4234597 link false /test e2e-openshift-conformance-sig-api-machinery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cooktheryan
Copy link
Contributor

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 2, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cooktheryan
To complete the pull request process, please ask for approval from sallyom after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants