USHIFT-2927: Remove fstab workaround in kickstart

[runcom]

bootc-dev/bootc#417 has landed to support a workaround directly on the bootc side.

[ggiguash]

/retitle USHIFT-2927: Remove fstab workaround in kickstart

[openshift-ci-robot]

@runcom: This pull request references USHIFT-2927 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

bootc-dev/bootc#417 has landed to support a workaround directly on the bootc side.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ggiguash]

We do not fail CI when the service startup error is reported. I will check this in the local environment to see if the errors are no longer reported.
/hold

[ggiguash]

@runcom , it looks like the fix exists in CentOS 9 Stream, but not in RHEL 9.4.

# cat /etc/redhat-release 
Red Hat Enterprise Linux release 9.4 (Plow)

# grep rhel-root /etc/fstab 
/dev/mapper/rhel-root / xfs defaults,ro 0 0

# systemctl status bootc-generic-growpart.service | cat
× bootc-generic-growpart.service - Bootc Fallback Root Filesystem Grow
     Loaded: loaded (/usr/lib/systemd/system/bootc-generic-growpart.service; static)
     Active: failed (Result: exit-code) since Fri 2024-10-25 06:24:56 UTC; 3min 32s ago
   Duration: 11ms
       Docs: https://gitlab.com/fedora/bootc/docs
    Process: 666 ExecStart=/usr/libexec/bootc-generic-growpart (code=exited, status=1/FAILURE)
   Main PID: 666 (code=exited, status=1/FAILURE)
        CPU: 7ms

Oct 25 06:24:56 localhost systemd[1]: Started Bootc Fallback Root Filesystem Grow.
Oct 25 06:24:56 localhost bootc-generic-growpart[666]: Backing device: /dev/mapper/rhel-root
Oct 25 06:24:56 localhost bootc-generic-growpart[666]: failed to find backing device /sys/class/block/rhel-root
Oct 25 06:24:56 localhost systemd[1]: bootc-generic-growpart.service: Main process exited, code=exited, status=1/FAILURE
Oct 25 06:24:56 localhost systemd[1]: bootc-generic-growpart.service: Failed with result 'exit-code'.

[ggiguash]

Strictly speaking, it's a different service / problem and it does not fail the boot sequence.
So, let's merge this fix and follow-up on this in the THEEDGE-4056 issue I just opened.
/unhold
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ggiguash]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ggiguash]

/retest-required

[runcom]

So, let's merge this fix and follow-up on this in the THEEDGE-4056 issue I just opened.

I'll look into this, if it's in c9s but not in rhel 9.4, perhaps we need just a backport

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 932d017 and 2 for PR HEAD 675c4ba in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 477b177 and 2 for PR HEAD 675c4ba in total