Skip to content

USHIFT-4712: Fix tests and node configuration for CNCF conformance #4092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 24, 2024
Merged

USHIFT-4712: Fix tests and node configuration for CNCF conformance #4092

merged 3 commits into from
Oct 24, 2024

Conversation

pacevedom
Copy link
Contributor

Which issue(s) this PR addresses:

Closes #

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 23, 2024 •
edited by openshift-ci bot
Loading

@pacevedom: This pull request references USHIFT-4712 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 23, 2024
@pacevedom
Copy link
Contributor Author

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 23, 2024

@pacevedom: The following commands are available to trigger required jobs:

  • /test e2e-aws-footprint-and-performance
  • /test e2e-aws-tests
  • /test e2e-aws-tests-arm
  • /test e2e-aws-tests-bootc
  • /test e2e-aws-tests-bootc-arm
  • /test e2e-aws-tests-bootc-periodic
  • /test e2e-aws-tests-bootc-periodic-arm
  • /test e2e-aws-tests-cache
  • /test e2e-aws-tests-cache-arm
  • /test e2e-aws-tests-periodic
  • /test e2e-aws-tests-periodic-arm
  • /test images
  • /test ocp-full-conformance-rhel-eus
  • /test ocp-full-conformance-rhel-eus-arm
  • /test ocp-full-conformance-serial-rhel-eus
  • /test ocp-full-conformance-serial-rhel-eus-arm
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-e2e-aws-tests
  • pull-ci-openshift-microshift-main-e2e-aws-tests-arm
  • pull-ci-openshift-microshift-main-e2e-aws-tests-bootc
  • pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm
  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from agullon and jerpeter1 October 23, 2024 14:50
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2024
@pacevedom
Copy link
Contributor Author

/test e2e-aws-tests-periodic

@pacevedom pacevedom changed the title USHIFT-4712: Fix second node configuration for CNCF conformance USHIFT-4712: Fix tests and node configuration for CNCF conformance Oct 23, 2024
@pacevedom
Copy link
Contributor Author

/test e2e-aws-tests-periodic

@pacevedom pacevedom force-pushed the USHIFT-4712 branch 2 times, most recently from 8360d92 to df01245 Compare October 23, 2024 17:56
@pacevedom
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2024
@pacevedom
Copy link
Contributor Author

/override ci/prow/e2e-aws-tests-periodic
Failures from FIPS tests in https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_microshift/4092/pull-ci-openshift-microshift-main-e2e-aws-tests-periodic/1849350186288025600 are not related to this change.
CNCF conformance in that link works again, which is the target for this PR.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

@pacevedom: Overrode contexts on behalf of pacevedom: ci/prow/e2e-aws-tests-periodic

In response to this:

/override ci/prow/e2e-aws-tests-periodic
Failures from FIPS tests in https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_microshift/4092/pull-ci-openshift-microshift-main-e2e-aws-tests-periodic/1849350186288025600 are not related to this change.
CNCF conformance in that link works again, which is the target for this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pmtk
Copy link
Member

pmtk commented Oct 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacevedom
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3ed7f01 into openshift:main Oct 24, 2024
10 checks passed
@pacevedom
Copy link
Contributor Author

/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link

@pacevedom: new pull request created: #4100

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 24, 2024
Closed
@pacevedom pacevedom mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agullon agullon Awaiting requested review from agullon

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

Assignees

@pmtk pmtk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pacevedom @openshift-ci-robot @pmtk @openshift-cherrypick-robot