Skip to content

Conversation

copejon
Copy link
Contributor

@copejon copejon commented Nov 2, 2021

Service name should indicate it's intent as a lifecycle manager for containerized microshift and to match the naming convention in the directory (script -> script.service).

@openshift-ci openshift-ci bot requested review from oglok and sallyom November 2, 2021 15:42
@netlify
Copy link

netlify bot commented Nov 2, 2021

✔️ Deploy Preview for microshift ready!

🔨 Explore the source changes: 55b394a

🔍 Inspect the deploy log: https://app.netlify.com/sites/microshift/deploys/618160a874030500084ee675

😎 Browse the preview: https://deploy-preview-410--microshift.netlify.app

@copejon copejon force-pushed the adjust-service-name branch from 30463bb to 50b8be1 Compare November 2, 2021 15:56
@mangelajo
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mangelajo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2021
@mangelajo
Copy link
Contributor

I had the same thought when I tried it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants