Skip to content

Conversation

ggiguash
Copy link
Contributor

A problem was discovered with how container images were preloaded for isolated tests in bootc configurations. This led to a question on why the isolated-network.robot tests were passing. Apparently, it was due to the post-containers.cfg configuration in kickstart that opened up access to the mirror registry from the isolated VMs. The network routing to the mirror registry on the hypervisor works via the libvirt bridge IP.

This PR addresses fixes the container image embedding in the bootc configurations, adds a test for verifying no container image access from VMs and introduces a dedicated kickstart (without container configuration) for isolated tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 30, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 30, 2024

@ggiguash: This pull request references USHIFT-4724 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

A problem was discovered with how container images were preloaded for isolated tests in bootc configurations. This led to a question on why the isolated-network.robot tests were passing. Apparently, it was due to the post-containers.cfg configuration in kickstart that opened up access to the mirror registry from the isolated VMs. The network routing to the mirror registry on the hypervisor works via the libvirt bridge IP.

This PR addresses fixes the container image embedding in the bootc configurations, adds a test for verifying no container image access from VMs and introduces a dedicated kickstart (without container configuration) for isolated tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2024
Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ggiguash ggiguash marked this pull request as ready for review October 30, 2024 08:08
@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 30, 2024
@openshift-ci openshift-ci bot requested review from eslutsky and jerpeter1 October 30, 2024 08:10
@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-periodic

Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2024
Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Contributor Author

/retest-required

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-bootc-periodic

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 15c15ba and 2 for PR HEAD bdadd1c in total

Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1f59c9a into openshift:main Oct 30, 2024
12 checks passed
@ggiguash ggiguash deleted the fix_isolated_tests branch October 31, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants