-
Notifications
You must be signed in to change notification settings - Fork 216
USHIFT-4724: Isolated tests must not have access to mirror registry #4118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USHIFT-4724: Isolated tests must not have access to mirror registry #4118
Conversation
@ggiguash: This pull request references USHIFT-4724 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
/test e2e-aws-tests-periodic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pacevedom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/test e2e-aws-tests-bootc-periodic |
@ggiguash: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
A problem was discovered with how container images were preloaded for isolated tests in bootc configurations. This led to a question on why the isolated-network.robot tests were passing. Apparently, it was due to the post-containers.cfg configuration in kickstart that opened up access to the mirror registry from the isolated VMs. The network routing to the mirror registry on the hypervisor works via the libvirt bridge IP.
This PR addresses fixes the container image embedding in the bootc configurations, adds a test for verifying no container image access from VMs and introduces a dedicated kickstart (without container configuration) for isolated tests.