Skip to content

USHIFT-4078: Wait for vg-manager to exist before waiting for availability #4186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2024
Merged

USHIFT-4078: Wait for vg-manager to exist before waiting for availability #4186

merged 1 commit into from
Nov 19, 2024

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Nov 15, 2024

No description provided.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 15, 2024 •
edited by openshift-ci bot
Loading

@pmtk: This pull request references USHIFT-4078 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 15, 2024
@openshift-ci openshift-ci bot requested review from ggiguash and jogeo November 15, 2024 15:32
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2024
@pmtk
Copy link
Member Author

pmtk commented Nov 18, 2024

/retest-required

@pmtk
Copy link
Member Author

pmtk commented Nov 18, 2024

/test e2e-aws-tests

@pacevedom
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2024
@pacevedom
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2024
pacevedom
pacevedom approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024 •
edited
Loading

@pmtk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 22f6056 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cacaef4 and 2 for PR HEAD 22f6056 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8921062 and 1 for PR HEAD 22f6056 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 7ba21e9 into openshift:main Nov 19, 2024
8 of 9 checks passed
@pmtk
Copy link
Member Author

pmtk commented Nov 21, 2024

/cherrypick release-4.17

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 21, 2024
Merged
@openshift-cherrypick-robot
Copy link

@pmtk: new pull request created: #4210

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggiguash ggiguash Awaiting requested review from ggiguash

@jogeo jogeo Awaiting requested review from jogeo

1 more reviewer

@pacevedom pacevedom pacevedom approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@pacevedom pacevedom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmtk @openshift-ci-robot @pacevedom @openshift-cherrypick-robot