Skip to content

USHIFT-4519: Recover and re-panic certain subcomponents #4196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2024
Merged

USHIFT-4519: Recover and re-panic certain subcomponents #4196

merged 1 commit into from
Nov 21, 2024

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Nov 18, 2024

Go's recover() only works within a go routine.
If the service spawns a Go routine to run the component, the recover() in service manager won't catch potential panics.

@pmtk
Recover and repanic certain subcomponents
0f9692a 
Go's recover() only works within a go routine.
If the service spawns a Go routine to run the component, the recover()
in service manager won't catch potential panics.
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 18, 2024 •
edited by openshift-ci bot
Loading

@pmtk: This pull request references USHIFT-4519 which is a valid jira issue.

In response to this:

Go's recover() only works within a go routine.
If the service spawns a Go routine to run the component, the recover() in service manager won't catch potential panics.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 18, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2024
@pmtk
Copy link
Member Author

pmtk commented Nov 18, 2024

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

@pmtk: The following commands are available to trigger required jobs:

  • /test e2e-aws-footprint-and-performance
  • /test e2e-aws-tests
  • /test e2e-aws-tests-arm
  • /test e2e-aws-tests-bootc
  • /test e2e-aws-tests-bootc-arm
  • /test e2e-aws-tests-bootc-periodic
  • /test e2e-aws-tests-bootc-periodic-arm
  • /test e2e-aws-tests-cache
  • /test e2e-aws-tests-cache-arm
  • /test e2e-aws-tests-periodic
  • /test e2e-aws-tests-periodic-arm
  • /test images
  • /test ocp-full-conformance-optional-components-rhel-eus
  • /test ocp-full-conformance-optional-components-rhel-eus-arm
  • /test ocp-full-conformance-rhel-eus
  • /test ocp-full-conformance-rhel-eus-arm
  • /test ocp-full-conformance-serial-optional-components-rhel-eus
  • /test ocp-full-conformance-serial-optional-components-rhel-eus-arm
  • /test ocp-full-conformance-serial-rhel-eus
  • /test ocp-full-conformance-serial-rhel-eus-arm
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test security
  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-e2e-aws-tests
  • pull-ci-openshift-microshift-main-e2e-aws-tests-arm
  • pull-ci-openshift-microshift-main-e2e-aws-tests-bootc
  • pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm
  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-security
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pmtk
Copy link
Member Author

pmtk commented Nov 18, 2024

/test e2e-aws-tests-bootc-periodic-arm e2e-aws-tests-periodic-arm

@pmtk
Copy link
Member Author

pmtk commented Nov 18, 2024

/test e2e-aws-tests-periodic e2e-aws-tests-bootc-periodic

@pmtk pmtk marked this pull request as ready for review November 19, 2024 08:40
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2024
@pmtk
Copy link
Member Author

pmtk commented Nov 19, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2024
@openshift-ci openshift-ci bot requested review from jogeo and pacevedom November 19, 2024 08:42
@pmtk
Copy link
Member Author

pmtk commented Nov 19, 2024

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 19, 2024

@pmtk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 0f9692a link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pmtk
Copy link
Member Author

pmtk commented Nov 20, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2024
pacevedom
pacevedom approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4de142b into openshift:main Nov 21, 2024
12 of 13 checks passed
@pmtk
Copy link
Member Author

pmtk commented Nov 28, 2024

/cherry-pick release-4.17

@pmtk pmtk deleted the recover-and-repanic branch November 28, 2024 15:37
@openshift-cherrypick-robot
Copy link

@pmtk: new pull request created: #4245

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogeo jogeo Awaiting requested review from jogeo

1 more reviewer

@pacevedom pacevedom pacevedom approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@pacevedom pacevedom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmtk @openshift-ci-robot @openshift-cherrypick-robot @pacevedom