USHIFT-4737: Add tag and digest capabilities to mirror script

[pacevedom]

Which issue(s) this PR addresses:

Closes #

[openshift-ci-robot]

@pacevedom: This pull request references USHIFT-4737 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ggiguash]

What about dir_to_registry function? Should we not change it?

[pacevedom]

Changed it to extend tag mirroring to the 2-phase approach as well. See #4214 (comment)

[ggiguash]

@pacevedom , can we verify that, besides CI, https://github.com/openshift/microshift/blob/main/docs/user/howto_mirror_images.md instructions work after this change?

[ggiguash]

@pacevedom , we also need to verify that this production doc is correct and open a bug otherwise:
https://docs.redhat.com/en/documentation/red_hat_build_of_microshift/4.17/html/embedding_in_a_rhel_for_edge_image/microshift-deploy-with-mirror-registry#microshift-configuring-hosts-for-mirror_microshift-deployment-mirror

[pacevedom]

@pacevedom , can we verify that, besides CI, https://github.com/openshift/microshift/blob/main/docs/user/howto_mirror_images.md instructions work after this change?

Yes, this is also why the dir-to-reg was changed, to preserve the tag capabilities that the one-shot mirror has. I tested with the output from a build phase in CI (container-images-list), both reg-to-dir and dir-to-reg to a local registry.

@pacevedom , we also need to verify that this production doc is correct and open a bug otherwise: https://docs.redhat.com/en/documentation/red_hat_build_of_microshift/4.17/html/embedding_in_a_rhel_for_edge_image/microshift-deploy-with-mirror-registry#microshift-configuring-hosts-for-mirror_microshift-deployment-mirror

This needs an update now, as there are no counters for temporary tags anymore and its also capable of mirroring tags, not just sha's.

[ggiguash]

I opened the OCPBUGS-44921 issue for production docs follow-up.

[ggiguash]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ggiguash,pacevedom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@pacevedom: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	0f848ac	link	false	/test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.