Skip to content

Conversation

ggiguash
Copy link
Contributor

The following enhancements were implemented to speed up mirroring and builds in general:

  • Add cache-to and cache-from options to bootc image builds for storing layers in the local registry rather than local storage
  • Remove elevation from dnf query and download commands to avoid potentially slow subscription updates (for common environment initialization and also in ostree builds)
  • The mirror registry script now explicitly adds non-localhost FROM container images to the list
  • The mirror registry script now checks the local mirror before attempting to download the images

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2024

@ggiguash: This pull request references USHIFT-4881 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

The following enhancements were implemented to speed up mirroring and builds in general:

  • Add cache-to and cache-from options to bootc image builds for storing layers in the local registry rather than local storage
  • Remove elevation from dnf query and download commands to avoid potentially slow subscription updates (for common environment initialization and also in ostree builds)
  • The mirror registry script now explicitly adds non-localhost FROM container images to the list
  • The mirror registry script now checks the local mirror before attempting to download the images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from agullon and eslutsky November 26, 2024 07:06
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@ggiguash
Copy link
Contributor Author

/test security

@ggiguash ggiguash force-pushed the bootc_local_mirror_builds branch from 0933b58 to cd23c44 Compare November 28, 2024 16:17
@pmtk
Copy link
Member

pmtk commented Nov 28, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2024
Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1291a37 and 2 for PR HEAD cd23c44 in total

Copy link
Contributor

openshift-ci bot commented Nov 29, 2024

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 199b9bb into openshift:main Nov 29, 2024
13 checks passed
@ggiguash ggiguash deleted the bootc_local_mirror_builds branch November 29, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants