Skip to content

USHIFT-5083: Always use qualified commit references in bootc kickstart #4249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 4, 2024
Merged

USHIFT-5083: Always use qualified commit references in bootc kickstart #4249

merged 4 commits into from
Dec 4, 2024

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Nov 29, 2024 •
edited
Loading

Only review this commit. The others are fixing a build problem that's not been merged yet.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 29, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 29, 2024 •
edited by openshift-ci bot
Loading

@ggiguash: This pull request references USHIFT-5083 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from copejon and jogeo November 29, 2024 08:48
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 29, 2024 •
edited by openshift-ci bot
Loading

@ggiguash: This pull request references USHIFT-5083 which is a valid jira issue.

In response to this:

Only review this commit. The others are fixing a build problem that's not been merged yet.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor Author

/test 2e-aws-tests-periodic

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 29, 2024

@ggiguash: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws-footprint-and-performance

/test e2e-aws-tests

/test e2e-aws-tests-arm

/test e2e-aws-tests-bootc

/test e2e-aws-tests-bootc-arm

/test e2e-aws-tests-bootc-periodic

/test e2e-aws-tests-bootc-periodic-arm

/test e2e-aws-tests-cache

/test e2e-aws-tests-cache-arm

/test e2e-aws-tests-periodic

/test e2e-aws-tests-periodic-arm

/test images

/test ocp-full-conformance-optional-components-rhel-eus

/test ocp-full-conformance-optional-components-rhel-eus-arm

/test ocp-full-conformance-rhel-eus

/test ocp-full-conformance-rhel-eus-arm

/test ocp-full-conformance-serial-optional-components-rhel-eus

/test ocp-full-conformance-serial-optional-components-rhel-eus-arm

/test ocp-full-conformance-serial-rhel-eus

/test ocp-full-conformance-serial-rhel-eus-arm

/test test-rpm

/test test-unit

/test verify

The following commands are available to trigger optional jobs:

/test security

/test test-rebase

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-microshift-main-e2e-aws-tests

pull-ci-openshift-microshift-main-e2e-aws-tests-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-periodic

pull-ci-openshift-microshift-main-e2e-aws-tests-periodic-arm

pull-ci-openshift-microshift-main-images

pull-ci-openshift-microshift-main-security

pull-ci-openshift-microshift-main-test-unit

pull-ci-openshift-microshift-main-verify

In response to this:

/test 2e-aws-tests-periodic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests-periodic

Tagging '192.168.122.1:5000/rhel9/rhel-bootc' as 'latest'
Tagging '192.168.122.1:5000/ubi9' as 'latest'
time="2024-11-29T09:41:20Z" level=fatal msg="copying image 4/4 from manifest list: reading blob sha256:f8b035150618a83f6e138b0843d47a77e1cb4d5fac81d3212df4533a74028272: fetching blob: received unexpected HTTP status: 500 Internal Server Error"
Tagging '192.168.122.1:5000/centos-bootc/centos-bootc' as 'latest'
time="2024-11-29T09:41:20Z" level=fatal msg="initializing source docker://192.168.122.1:5000/centos-bootc/centos-bootc:stream9: reading manifest stream9 in 192.168.122.1:5000/centos-bootc/centos-bootc: manifest unknown"

@pmtk
Copy link
Member

pmtk commented Dec 3, 2024

/lgtm
/hold

Unhold in right time :)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Contributor Author

ggiguash commented Dec 4, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2024
@ggiguash
Copy link
Contributor Author

ggiguash commented Dec 4, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2024
@ggiguash
Copy link
Contributor Author

ggiguash commented Dec 4, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ddc2e7f and 2 for PR HEAD abe529c in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c1f5947 and 2 for PR HEAD abe529c in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c1f5947 and 2 for PR HEAD abe529c in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0f9ac93 into openshift:main Dec 4, 2024
13 checks passed
@ggiguash
Copy link
Contributor Author

ggiguash commented Dec 5, 2024

/cherry-pick release-4.18

@ggiguash ggiguash deleted the fix_skopeo_fallback branch December 5, 2024 06:53
@openshift-cherrypick-robot
Copy link

@ggiguash: new pull request created: #4276

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copejon copejon Awaiting requested review from copejon

@jogeo jogeo Awaiting requested review from jogeo

Assignees

@pmtk pmtk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggiguash @openshift-ci-robot @pmtk @openshift-cherrypick-robot